-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Text.Json.SourceGeneration.Unit.Tests are disabled in WASM #58226
Comments
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsOur System.Text.Json.SourceGeneration.Tests use the following to add references to the compilation: Lines 31 to 37 in 7994e59
This doesn't work in If we feel we need to run these tests on
|
This is the case for all source generator unit tests that need to set up a compilation as part of the test, not just the System.Text.Json ones. Some of the others are disabled for other reasons beyond the |
- `Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests` - `Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests` - `System.Text.Json.SourceGeneration.Roslyn3.11.Unit.Tests` - `System.Text.Json.SourceGeneration.Roslyn4.0.Unit.Tests` - `System.Text.RegularExpressions.Generators.Tests` Some individual ones are disabled due to dotnet#58226, and dotnet#60899 . Fixes dotnet#51961 .
This adds support for setting per-project optimization flags, and sets them for these projects so they don't OOM. Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests System.Text.Json.SourceGeneration.Roslyn3.11.Unit.Tests System.Text.Json.SourceGeneration.Roslyn4.0.Unit.Tests System.Text.RegularExpressions.Generators.Tests Some individual ones are disabled due to #58226, and #60899 . Additionally, if a AOT build fails, then on linux it dumps the last few lines from dmesg, to help identify it was an oom-kill. Fixes #51961 . Co-authored-by: Larry Ewing <[email protected]>
Our System.Text.Json.SourceGeneration.Tests use the following to add references to the compilation:
runtime/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.UnitTests/CompilationHelper.cs
Lines 31 to 37 in 7994e59
This doesn't work in
browser-wasm
becauseAssembly.Location
returnsstring.Empty
. Thus we get exceptions that empty string is not a valid file path.If we feel we need to run these tests on
browser-wasm
, we need to figure out a way to reference these assemblies so Roslyn can compile code.cc @lewing @radical
The text was updated successfully, but these errors were encountered: