Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataSet/DataTable code paths for SerializationFormat.Binary #65140

Open
roji opened this issue Feb 10, 2022 · 5 comments
Open

Remove DataSet/DataTable code paths for SerializationFormat.Binary #65140

roji opened this issue Feb 10, 2022 · 5 comments
Assignees
Labels
area-System.Data binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it
Milestone

Comments

@roji
Copy link
Member

roji commented Feb 10, 2022

Following the obsoletion of SerializationFormat.Binary and putting it behind an appcontext switch in .NET 7.0 (#39289), we should remove the code paths which support it, and which contain BinaryFormatter usage.

@roji roji added this to the Future milestone Feb 10, 2022
@roji roji self-assigned this Feb 10, 2022
@ghost
Copy link

ghost commented Feb 10, 2022

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Following the obsoletion of SerializationFormat.Binary and putting it behind an appcontext switch in .NET 7.0 (#39289), we should remove the code paths which support it, and which contain BinaryFormatter usage.

Author: roji
Assignees: roji
Labels:

area-System.Data

Milestone: Future

@stephentoub
Copy link
Member

cc: @GrabYourPitchforks

@Wraith2
Copy link
Contributor

Wraith2 commented Feb 11, 2022

Is #39397 what you're looking to do?

@roji
Copy link
Member Author

roji commented Feb 12, 2022

@Wraith2 more or less, yeah - but with a more gradual approach. For .NET 7.0 I've just merged #65139, which both obsoletes and adds a runtime check to throw - but still allows an appcontext switch to be used to opt into using SerializationFormat.Binary. This issue would remove the code entirely in .NET 8.0, so even the appcontext switch would no longer work.

@Wraith2
Copy link
Contributor

Wraith2 commented Feb 12, 2022

Ok. I was just wondering if that one would have saved you from having to do all the work, seems not.

@ajcvickers ajcvickers removed the untriaged New issue has not been triaged by the area owner label Feb 14, 2022
@roji roji modified the milestones: Future, 8.0.0 Oct 20, 2022
@roji roji modified the milestones: 8.0.0, 9.0.0 Apr 25, 2024
@jkotas jkotas added the binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it label May 29, 2024
@SamMonoRT SamMonoRT modified the milestones: 9.0.0, 10.0.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Data binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it
Projects
None yet
Development

No branches or pull requests

6 participants