Obsolete and put SerializationFormat.Binary behind an appcontext switch #65139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this obsoletes System.Data's SerializationFormat.Binary, and adds checks to throw if DataTable/DataSet's RemotingFormat property is set to it, or if the serialization constructor encounters data with it. Added the appcontext switch
Switch.System.Data.AllowUnsafeSerializationFormatBinary
to allow this to still be used in .NET 7.0; we'd remove these code paths entirely in .NET 8.0.Part of #39289
/cc @ajcvickers @jeffhandley @blowdart @bricelam