Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Threading.ThreadPools.Tests.ThreadPoolTests.CooperativeBlockingCanCreateThreadsFaster has failed #66755

Closed
ilonatommy opened this issue Mar 17, 2022 · 6 comments

Comments

@ilonatommy
Copy link
Member

Failing in rolling build: Libraries Test Run release coreclr OSX x64 Release, but not every time. In 20220315.1 and 20220315.4 it failed, then in 20220316.1 it passed and in 20220316.4 it failed again.

The error:

Unhandled exception. Xunit.Sdk.TrueException: Assert.True() Failure
Expected: True
Actual:   False
   at System.Threading.ThreadPools.Tests.ThreadPoolTests.<>c.<CooperativeBlockingCanCreateThreadsFaster>b__38_0() in /_/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs:line 953
--- End of stack trace from previous location ---
   at Microsoft.DotNet.RemoteExecutor.Program.Main(String[] args) in /_/src/Microsoft.DotNet.RemoteExecutor/src/Program.cs:line 94
    System.Threading.ThreadPools.Tests.ThreadPoolTests.CooperativeBlockingCanCreateThreadsFaster [FAIL]
      Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
      Stack Trace:
        
        Child exception:
          Xunit.Sdk.TrueException: Assert.True() Failure
        Expected: True
        Actual:   False
        /_/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs(953,0): at System.Threading.ThreadPools.Tests.ThreadPoolTests.<>c.<CooperativeBlockingCanCreateThreadsFaster>b__38_0()
        
        Child process:
          System.Threading.ThreadPool.Tests, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 System.Threading.ThreadPools.Tests.ThreadPoolTests+<>c Void <CooperativeBlockingCanCreateThreadsFaster>b__38_0()

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Threading untriaged New issue has not been triaged by the area owner labels Mar 17, 2022
@ghost
Copy link

ghost commented Mar 17, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Failing in rolling build: Libraries Test Run release coreclr OSX x64 Release, but not every time. In 20220315.1 and 20220315.4 it failed, then in 20220316.1 it passed and in 20220316.4 it failed again.

The error:

Unhandled exception. Xunit.Sdk.TrueException: Assert.True() Failure
Expected: True
Actual:   False
   at System.Threading.ThreadPools.Tests.ThreadPoolTests.<>c.<CooperativeBlockingCanCreateThreadsFaster>b__38_0() in /_/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs:line 953
--- End of stack trace from previous location ---
   at Microsoft.DotNet.RemoteExecutor.Program.Main(String[] args) in /_/src/Microsoft.DotNet.RemoteExecutor/src/Program.cs:line 94
    System.Threading.ThreadPools.Tests.ThreadPoolTests.CooperativeBlockingCanCreateThreadsFaster [FAIL]
      Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
      Stack Trace:
        
        Child exception:
          Xunit.Sdk.TrueException: Assert.True() Failure
        Expected: True
        Actual:   False
        /_/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs(953,0): at System.Threading.ThreadPools.Tests.ThreadPoolTests.<>c.<CooperativeBlockingCanCreateThreadsFaster>b__38_0()
        
        Child process:
          System.Threading.ThreadPool.Tests, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 System.Threading.ThreadPools.Tests.ThreadPoolTests+<>c Void <CooperativeBlockingCanCreateThreadsFaster>b__38_0()

Author: ilonatommy
Assignees: -
Labels:

area-System.Threading, untriaged

Milestone: -

@ilonatommy
Copy link
Member Author

@kouvel, any ideas what might have caused it?

@kouvel kouvel self-assigned this Mar 17, 2022
@kouvel kouvel removed the untriaged New issue has not been triaged by the area owner label Mar 17, 2022
@kouvel kouvel added this to the 7.0.0 milestone Mar 17, 2022
@kouvel
Copy link
Member

kouvel commented Mar 17, 2022

I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Trying a fix here: #66765

@ilonatommy
Copy link
Member Author

@kouvel, thank you for looking into it but even on the #66765 the check failed so it seems it's not the fix we're looking for. How else can we get rid of this error?

@kouvel
Copy link
Member

kouvel commented Mar 18, 2022

All of those failures appear to be crashes on Mono. Maybe the in-proc event listener is not fully implemented there. I'll file an issue and disable the test on Mono for now.

@kouvel
Copy link
Member

kouvel commented Mar 19, 2022

Closing as a duplicate of #66852, which seems to be tracking failures of this test elsewhere by a bot

@kouvel kouvel closed this as completed Mar 19, 2022
kouvel added a commit to kouvel/runtime that referenced this issue Mar 22, 2022
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.

Hopefully fixes dotnet#66755
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants