Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger][tests] Possible race condition seen in DebuggerTests.BreakpointTests.JSConditionalBreakpoint #69144

Closed
radical opened this issue May 10, 2022 · 1 comment · Fixed by #73524
Closed

[wasm][debugger][tests] Possible race condition seen in DebuggerTests.BreakpointTests.JSConditionalBreakpoint #69144

radical opened this issue May 10, 2022 · 1 comment · Fixed by #73524
Assignees
@radical
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone
7.0.0

Comments

@radical
Copy link
Member

radical commented May 10, 2022

Log:

  Failed DebuggerTests.BreakpointTests.JSConditionalBreakpoint(condition: "0.0", line_bp: 79, column_bp: 3, line_expected: 80, column_expected: 11) [52 ms]
  Error Message:
   System.IndexOutOfRangeException : Index was outside the bounds of the array.
  Stack Trace:
     at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.set_Item(TKey key, TValue value)
   at DebuggerTests.Inspector.WaitFor(String what) in /_/src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs:line 82
   at DebuggerTests.DebuggerTestBase.WaitFor(String what) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 222
   at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 549
   at DebuggerTests.DebuggerTestBase.EvaluateAndCheck(String expression, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 533
   at DebuggerTests.BreakpointTests.JSConditionalBreakpoint(String condition, Int32 line_bp, Int32 column_bp, Int32 line_expected, Int32 column_expected) in /_/src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs:line 232
--- End of stack trace from previous location ---
@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels May 10, 2022
@radical radical self-assigned this May 10, 2022
@ghost
Copy link

ghost commented May 10, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Log:

  Failed DebuggerTests.BreakpointTests.JSConditionalBreakpoint(condition: "0.0", line_bp: 79, column_bp: 3, line_expected: 80, column_expected: 11) [52 ms]
  Error Message:
   System.IndexOutOfRangeException : Index was outside the bounds of the array.
  Stack Trace:
     at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.set_Item(TKey key, TValue value)
   at DebuggerTests.Inspector.WaitFor(String what) in /_/src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs:line 82
   at DebuggerTests.DebuggerTestBase.WaitFor(String what) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 222
   at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 549
   at DebuggerTests.DebuggerTestBase.EvaluateAndCheck(String expression, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 533
   at DebuggerTests.BreakpointTests.JSConditionalBreakpoint(String condition, Int32 line_bp, Int32 column_bp, Int32 line_expected, Int32 column_expected) in /_/src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs:line 232
--- End of stack trace from previous location ---
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 10, 2022
@radical radical removed the untriaged New issue has not been triaged by the area owner label May 10, 2022
@radical radical mentioned this issue May 10, 2022
Merged
@thaystg thaystg added this to the 7.0.0 milestone Jul 5, 2022
radical added a commit to radical/runtime that referenced this issue Aug 7, 2022
@radical
[wasm][debugger][tests] Use ConcurrentDictionary for event listeners,
f6d561b 
.. and notification handlers, since they can be modified from different
threads.

Fixes dotnet#69144 .
@radical radical mentioned this issue Aug 7, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 7, 2022
@radical radical closed this as completed in 8858001 Aug 9, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[wasm][debugger] Fix some racy tests radical/runtime
2 participants
@radical @thaystg