Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mono support for default interface implementations of static virtual methods #70040

Closed
trylek opened this issue May 31, 2022 · 6 comments
Assignees
Milestone

Comments

@trylek
Copy link
Member

trylek commented May 31, 2022

I believe I'm close to merging in the PR enabling SVM default interface implementations in CoreCLR,

#66887

Naturally the mono legs of the PR run are now failing in the new test due to incomplete mono implementation. I'm creating this issue to temporarily block the new svm_diamondshape test in issues.targets before the mono support is implemented.

/cc @SamMonoRT

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 31, 2022
@trylek trylek added area-Codegen-JIT-mono and removed untriaged New issue has not been triaged by the area owner labels May 31, 2022
trylek added a commit to trylek/runtime that referenced this issue May 31, 2022


Disable the test before the Mono support is provided.
@SamMonoRT
Copy link
Member

@BrzVlad - your PR is now merged #69738

@trylek - does the test fail with Vlad's PR ?

@SamMonoRT SamMonoRT added this to the 7.0.0 milestone May 31, 2022
@trylek
Copy link
Member Author

trylek commented May 31, 2022

Hmm, it was failing yesterday, if the fix has just been merged in, I don't yet have an updated reading, I'll launch another lab run on the change without the issues.targets addition.

@trylek
Copy link
Member Author

trylek commented May 31, 2022

It looks good, there's just one remaining leg that hasn't finished yet and the rest are all green, once they are done I'll add this commit to the main PR and I'll close the bug as resolved.

@lambdageek
Copy link
Member

@trylek Mono issue is resolved now?

@trylek
Copy link
Member Author

trylek commented Jun 1, 2022

I believe so, Mono legs have passed with my change, the only remaining concern is NativeAOT, I need to work with @MichalStrehovsky and / or @jkotas to figure out what needs to be done there as I'm not a NativeAOT expert yet.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants