Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fetching assemblies in the debug proxy is (possibly) slower now #70807

Closed
3 tasks
radical opened this issue Jun 16, 2022 · 1 comment · Fixed by #89525
Closed
3 tasks

[wasm][debugger] Fetching assemblies in the debug proxy is (possibly) slower now #70807

radical opened this issue Jun 16, 2022 · 1 comment · Fixed by #89525
Assignees
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone

Comments

@radical
Copy link
Member

radical commented Jun 16, 2022

Improve how the proxy acquires the assemblies

With #69072, the debugger tests/chrome started timing out on Windows after 1 hour. Without that PR, they take 35-40mins. (Note: the tests pass on main because the timeout was bumped to 90mins).

  • We need to figure out a better way to do this, or fetch the base64 encoded assemblies only when we need them. For example, we could try http, if that's available, and use base64 as a fallback.
  • Is there a better way to get these assemblies from the app? IIUC, with the current way (sending in a cdp message), we are limited to that single connection vs multiple parallel downloads in case of fetching via http.
  • Is it possible to have multiple cdp connections to the app, to get these?

cc @lewing @thaystg @ilonatommy

@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels Jun 16, 2022
@ghost
Copy link

ghost commented Jun 16, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Improve how the proxy acquires the assemblies

With #69072, the debugger tests/chrome started timing out on Windows after 1 hour. Without that PR, they take 35-40mins.

  • We need to figure out a better way to do this, or fetch the base64 encoded assemblies only when we need them. For example, we could try http, if that's available, and use base64 as a fallback.
  • Is there a better way to get these assemblies from the app? IIUC, with the current way (sending in a cdp message), we are limited to that single connection vs multiple parallel downloads in case of fetching via http.
  • Is it possible to have multiple cdp connections to the app, to get these?

cc @lewing @thaystg @ilonatommy

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 16, 2022
@radical radical changed the title [wasm][debugger] Fetching assemblies in the debug proxy is slower [wasm][debugger] Fetching assemblies in the debug proxy is (possibly) slower now Jun 16, 2022
@radical radical removed the untriaged New issue has not been triaged by the area owner label Jun 16, 2022
@radical radical added this to the 7.0.0 milestone Jun 16, 2022
@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 25, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 26, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants