Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] CI improvements to improve test coverage, and reduce load #74538

Open
13 of 23 tasks
radical opened this issue Aug 24, 2022 · 4 comments
Open
13 of 23 tasks

[wasm] CI improvements to improve test coverage, and reduce load #74538

radical opened this issue Aug 24, 2022 · 4 comments
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono tracking This issue is tracking the completion of other related issues.
Milestone

Comments

@radical
Copy link
Member

radical commented Aug 24, 2022

Reduce load

  • Improve detection of darc updates allowing the use of specific dependency updates to control triggering of builds. Example: emsdk update should only trigger wasm builds
    • This is difficult right now because the version gets updated in eng/Versions.props, but since it has lot of other things too, all the builds get triggered.
    • If instead the darc version properties were in a separate file, then we could easily figure out if only a darc dependency was updated
    • If not, then we could piece together this with a script
  • webcil task should trigger only wasm builds
  • Run chrome, and Firefox debugger tests in a single job (reducing 2 builds)
  • Run the AOT smoke test with the EAT job (reducing 1 build) - [wasm] CI: For linux, run AOT smoke tests with the EAT build #82570
  • Run the windows AOT test with windows library tests - [wasm] CI: For linux, run AOT smoke tests with the EAT build #82570
  • Explore having a few build jobs, and running the tests jobs based on the artifacts - Not doing this, as lesser compute for Build isn't important vs quicker PR runs.
  • wasi: add path checks (evaluate-default-paths.yml: Add paths for wasi #81817)
  • runtime-wasm-dbg-tests: For a PR, run only the jobs that didn't run on runtime pipeline
  • Audit the jobs running on the manual-only pipelines

For better test coverage

Explore

  • Explore identifying library test projects to run based on changes in src/libraries, so we can run them for wasm/AOT, without having to run all the tests
  • With the reduced need to run all the wasm tests manually via runtime-wasm, find some way to help the PR author figure out whether a manual run is needed.
  • auto-trigger runtime-wasm (with conditions) if extra tests need to be run
    • for example - when we have threading related changes, like the threading samples, then we want to run the threading tests in runtime-wasm, so auto-trigger those

These would apply, and benefit mono/mobile jobs too.

@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Aug 24, 2022
@radical radical self-assigned this Aug 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 24, 2022
@ghost
Copy link

ghost commented Aug 24, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Avoid triggering unrelated coreclr, and mono/mobile jobs based on wasm-only changes (CI: Tighten the path based triggers for jobs #74534)
  • Make all the unconditional coreclr build, coreclr library tests, dev-innerloop, and dotnet-linker-tests jobs conditional, so they don't get triggered on wasm-only changes
  • Explore having a few build jobs, and running the tests jobs based on the artifacts

These would apply, and benefit mono/mobile jobs too.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@radical radical removed the untriaged New issue has not been triaged by the area owner label Aug 24, 2022
@lewing
Copy link
Member

lewing commented Aug 25, 2022

cc @danmoseley @steveisok

@danmoseley
Copy link
Member

thanks for working on this @radical

@radical radical added this to the 8.0.0 milestone Aug 29, 2022
@marek-safar marek-safar added the tracking This issue is tracking the completion of other related issues. label Feb 8, 2023
@radical
Copy link
Member Author

radical commented Apr 18, 2023

Bumping this for myself, to note that we need to be better about running wasm aot tests on PRs. Some test failures like #85012 slipped through because the AOT tests were not run on runtime, or runtime-extra-platforms pipelines on the PRs.

@radical radical modified the milestones: 8.0.0, 9.0.0 Aug 2, 2023
@radical radical mentioned this issue Sep 20, 2023
2 tasks
@radical radical removed their assignment Feb 27, 2024
@ilonatommy ilonatommy modified the milestones: 9.0.0, Future Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono tracking This issue is tracking the completion of other related issues.
Projects
None yet
Development

No branches or pull requests

5 participants