Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

microsoft.extensions.logging.generators.roslyn4.0.tests work item #72836

Closed
runfoapp bot opened this issue Jul 26, 2022 · 9 comments
Closed

microsoft.extensions.logging.generators.roslyn4.0.tests work item #72836

runfoapp bot opened this issue Jul 26, 2022 · 9 comments
Assignees
@maryamariyan
Labels
area-Extensions-Logging os-tvos Apple tvOS
Milestone
7.0.0

Comments

@runfoapp
Copy link

runfoapp bot commented Jul 26, 2022 •
edited
Loading

Build terminating in CI with little indication why on TvOS:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-03666e5d9e604c64bd/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests/1/console.c361ca0f.log?%3Fhelixlogtype%3Dresult

  [195/201] xunit.core.dll -> xunit.core.dll.s, xunit.core.dll-llvm.o, xunit.core.aotdata
  [196/201] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.s, xunit.execution.dotnet.dll-llvm.o, xunit.execution.dotnet.aotdata
  [197/201] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.s, xunit.runner.utility.netcoreapp10.dll-llvm.o, xunit.runner.utility.netcoreapp10.aotdata
./xharness-runner.apple.sh: line 173: 59453 Terminated: 15          source command.sh
Removing empty log files:
ls: /tmp/helix/working/AADA097D/w/A588093F/uploads/xunit-*.xml: No such file or directory
+ exit_code=143

Runfo Tracking Issue: microsoft.extensions.logging.generators.roslyn4.0.tests work item

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1904585 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py
1903274 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py
1902387 runtime-extra-platforms Rolling net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open console.log runclient.py
1902034 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py
1901961 runtime-extra-platforms PR 72802 net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open console.log runclient.py
1901068 runtime-extra-platforms Rolling net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open console.log runclient.py
1900887 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py
1900783 runtime-extra-platforms PR 67861 net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open console.log runclient.py
1900783 runtime-extra-platforms PR 67861 net7.0-MacCatalyst-Release-arm64-Mono_Release-OSX.1200.Arm64.Open console.log runclient.py
1900774 runtime-extra-platforms PR 72545 net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open console.log runclient.py
1900571 runtime-extra-platforms Rolling net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open console.log runclient.py
1900480 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py
1900064 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py
1899653 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py
1899117 runtime-extra-platforms Rolling net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125 console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
2 14 14
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 26, 2022
@noahfalk noahfalk added the os-tvos Apple tvOS label Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

Tagging subscribers to 'os-tvos': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Build terminating in CI with little indication why on TvOS:

[195/201] xunit.core.dll -> xunit.core.dll.s, xunit.core.dll-llvm.o, xunit.core.aotdata
[196/201] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.s, xunit.execution.dotnet.dll-llvm.o, xunit.execution.dotnet.aotdata
[197/201] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.s, xunit.runner.utility.netcoreapp10.dll-llvm.o, xunit.runner.utility.netcoreapp10.aotdata
./xharness-runner.apple.sh: line 173: 59453 Terminated: 15 source command.sh
Removing empty log files:
ls: /tmp/helix/working/AADA097D/w/A588093F/uploads/xunit-*.xml: No such file or directory

  • exit_code=143

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

untriaged, os-tvos
Milestone: -

@noahfalk noahfalk added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jul 26, 2022
@noahfalk noahfalk mentioned this issue Jul 26, 2022
Open
@steveisok steveisok mentioned this issue Jul 26, 2022
Merged
@steveisok
Copy link
Member

The issue is the test suite untrimmed will generate an app size around 1GB. For whatever reason, the helix machines churn when trying to build it and end up timing out. The solution I think will work is to bring over the aggressive trimming test targets that exist in

runtime/eng/testing/tests.mobile.targets

Lines 179 to 217 in 73374e8

<Target Name="ConfigureTrimming" Condition="('$(EnableAggressiveTrimming)' == 'true' or '$(EnableSoftTrimming)' == 'true') And '$(SkipConfigureTrimming)' != 'true'" AfterTargets="AddTestRunnersToPublishedFiles">
<PropertyGroup>
<TrimMode Condition="'$(EnableAggressiveTrimming)' == 'true'">link</TrimMode>
<TrimMode Condition="'$(EnableSoftTrimming)' == 'true'">copyused</TrimMode>
</PropertyGroup>
<ItemGroup>
<!-- Mark all the assemblies for link. We will explicitly mark the non-trimmable ones -->
<ResolvedFileToPublish TrimMode="$(TrimMode)" />
<!-- Don't trim the main assembly.
TrimMode="" is needed so the root assemblies are correctly identified -->
<ResolvedFileToPublish TrimMode="" Condition="'%(FileName)' == '$(AssemblyName)'" />
<!-- TODO: find out why these assemblies aren't copied by copyused even though they're referenced -->
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.ComponentModel.EventBasedAsync'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Diagnostics.FileVersionInfo'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Drawing.Primitives'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.IO.Pipelines'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Memory'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Net.WebHeaderCollection'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Runtime.Serialization.Formatters'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Security.AccessControl'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Security.Claims'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Security.Permissions'" />
<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Transactions.Local'" />
<!-- Even though we are trimming the test runner assembly, we want it to be treated
as a root -->
<TrimmerRootAssembly
Condition="$([System.String]::Copy('%(ResolvedFileToPublish.FileName)%(ResolvedFileToPublish.Extension)').EndsWith('TestRunner.dll'))"
Include="%(ResolvedFileToPublish.FullPath)" />
</ItemGroup>
<ItemGroup>
<TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptor.xunit.xml" Condition="'$(SkipXunitTrimmerDescriptor)' != 'true'" />
<TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptor.TestUtilities.xml" Condition="'$(SkipTestUtilitiesReference)' != 'true'" />
</ItemGroup>
</Target>

That will bring the app size down to about 300MB, which the helix machines should be able to handle without much trouble. Until the targets and xml descriptor files are sent over, the tests should be skipped.

steveisok pushed a commit to steveisok/runtime that referenced this issue Jul 26, 2022
[iOS] Skip test suites that take too long to build on helix
30855e8 
System.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB.  The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably.

Skipping these tests for now.

Addresses dotnet#72834

Addresses dotnet#72836
@ghost
Copy link

ghost commented Jul 26, 2022

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Build terminating in CI with little indication why on TvOS:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-03666e5d9e604c64bd/Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests/1/console.c361ca0f.log?%3Fhelixlogtype%3Dresult

  [195/201] xunit.core.dll -> xunit.core.dll.s, xunit.core.dll-llvm.o, xunit.core.aotdata
  [196/201] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.s, xunit.execution.dotnet.dll-llvm.o, xunit.execution.dotnet.aotdata
  [197/201] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.s, xunit.runner.utility.netcoreapp10.dll-llvm.o, xunit.runner.utility.netcoreapp10.aotdata
./xharness-runner.apple.sh: line 173: 59453 Terminated: 15          source command.sh
Removing empty log files:
ls: /tmp/helix/working/AADA097D/w/A588093F/uploads/xunit-*.xml: No such file or directory
+ exit_code=143

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

blocking-clean-ci, untriaged, area-Extensions-Logging, os-tvos
Milestone: -

@runfoapp runfoapp bot mentioned this issue Jul 26, 2022
Closed
@eerhardt
Copy link
Member

Do we really need to run source generator tests on tvOS and MacCatalyst?

@steveisok
Copy link
Member

Do we really need to run source generator tests on tvOS and MacCatalyst?

Maybe? I don't know if it has value or not.

@eerhardt
Copy link
Member

IMHO - I believe it has very little value. I don't think we are running msbuild, sdk, roslyn, nuget, etc. tests on mobile form factors.

@danmoseley
Copy link
Member

I agree, I don't see the value unless it's helpful to stress the system in general.

@maryamariyan maryamariyan removed the untriaged New issue has not been triaged by the area owner label Jul 26, 2022
@maryamariyan maryamariyan modified the milestones: Future, 7.0.0 Jul 26, 2022
@maryamariyan maryamariyan added help wanted [up-for-grabs] Good issue for external contributors and removed help wanted [up-for-grabs] Good issue for external contributors labels Jul 26, 2022
@maryamariyan maryamariyan self-assigned this Jul 26, 2022
steveisok added a commit that referenced this issue Jul 27, 2022
@steveisok
[iOS] Skip test suites that take too long to build on helix (#72849)
c421a7c 
System.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB.  The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably.

Skipping these tests for now.

Addresses #72834

Addresses #72836
@steveisok steveisok removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jul 27, 2022
@steveisok
Copy link
Member

Since the test is disabled and we don't think running it makes sense, I'm going to close the issue.

@mdh1418 mdh1418 mentioned this issue Jul 27, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maryamariyan maryamariyan

Labels
area-Extensions-Logging os-tvos Apple tvOS
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
6 participants
@steveisok @maryamariyan @noahfalk @danmoseley @eerhardt @jeffschwMSFT