Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int128TestFieldLayout test failing on NativeAOT #74549

Closed
MichalStrehovsky opened this issue Aug 25, 2022 · 1 comment · Fixed by #88651
Closed

Int128TestFieldLayout test failing on NativeAOT #74549

MichalStrehovsky opened this issue Aug 25, 2022 · 1 comment · Fixed by #88651

Comments

@MichalStrehovsky
Copy link
Member

Return code:      1
Raw output file:      C:\git\runtime\artifacts\tests\coreclr\windows.x64.Debug\Reports\Interop.PInvoke\Int128\Int128TestFieldLayout\Int128TestFieldLayout.output.txt
Raw output:
BEGIN EXECUTION
call C:\git\runtime\src\tests\Common\scripts\nativeaottest.cmd C:\git\runtime\artifacts\tests\coreclr\windows.x64.Debug\Interop\PInvoke\Int128\Int128TestFieldLayout\ Int128TestFieldLayout.dll 
Testing Int128
System.Runtime.InteropServices.MarshalDirectiveException: Method '[Int128TestFieldLayout]Int128Native.AddStructWithInt128_ByRef(StructWithInt128&,StructWithInt128&)' requires marshalling that is not yet supported by this compiler.
   at Int128Native.AddStructWithInt128_ByRef(StructWithInt128&, StructWithInt128&) + 0x41
   at Int128Native.TestInt128FieldLayout() + 0xd0
   at Int128NativeFieldLayout.Main(String[]) + 0x2f
Expected: 100
Actual: 0
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:

I think this got blocked out in #74123.

Cc @davidwrighton

Cc @dotnet/interop-contrib for a bar check. I honestly don't know how common this could be and whether this is 7.0. The blocking was 7.0.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 25, 2022
@davidwrighton
Copy link
Member

I don't think this is blocking for .NET 7. Its a rather rare scenario, and the failure is only on the fail path. I would mark this as .NET 8.

@MichalStrehovsky MichalStrehovsky removed the untriaged New issue has not been triaged by the area owner label Aug 25, 2022
@MichalStrehovsky MichalStrehovsky added this to the 8.0.0 milestone Aug 25, 2022
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Jul 11, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 11, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants