Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPMI does not cleanly record/replay NAOT compilations #76925

Closed
jakobbotsch opened this issue Oct 12, 2022 · 2 comments · Fixed by #76996
Closed

SPMI does not cleanly record/replay NAOT compilations #76925

jakobbotsch opened this issue Oct 12, 2022 · 2 comments · Fixed by #76996
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
8.0.0

Comments

@jakobbotsch
Copy link
Member

When recording a collection through ilc I get a lot of the following messages when replaying the collection:

ERROR: Hit unimplemented expandRawHandleIntrinsic
ERROR: Exception thrown: DebugBreak or AV Exception 129
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 12, 2022
@jakobbotsch jakobbotsch added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 12, 2022
@ghost
Copy link

ghost commented Oct 12, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

When recording a collection through ilc I get a lot of the following messages when replaying the collection:

ERROR: Hit unimplemented expandRawHandleIntrinsic
ERROR: Exception thrown: DebugBreak or AV Exception 129
Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@jakobbotsch jakobbotsch removed the untriaged New issue has not been triaged by the area owner label Oct 12, 2022
@jakobbotsch jakobbotsch added this to the 8.0.0 milestone Oct 12, 2022
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Oct 13, 2022
@jakobbotsch
Implement expandRawHandleIntrinsic in SPMI
a404d0c 
Also fix NAOT passing garbage back to JIT.

Fix dotnet#76925
@jakobbotsch jakobbotsch mentioned this issue Oct 13, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 13, 2022
jakobbotsch added a commit that referenced this issue Oct 25, 2022
@jakobbotsch
SPMI: Implement missing NAOT support (and fix garbage values passed t…
afdd009 
…o JIT in expandRawHandleIntrinsic) (#76996)

Implement expandRawHandleIntrinsic in SPMI

Also fix NAOT passing garbage back to JIT.

Fix #76925
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 25, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
8.0.0
1 participant
@jakobbotsch