Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable PGO optimization for linux #84711

Closed
sbomer opened this issue Apr 12, 2023 · 3 comments · Fixed by #85355
Closed

Re-enable PGO optimization for linux #84711

sbomer opened this issue Apr 12, 2023 · 3 comments · Fixed by #85355
Assignees
@sbomer
Labels
area-Infrastructure-coreclr

Comments

@sbomer
Copy link
Member

sbomer commented Apr 12, 2023

#84148 turns off PGO optimization because it was hitting a compiler crash when consuming and old version of profile data produced by clang9 instrumented builds (https://bugzilla.redhat.com/show_bug.cgi?id=1827282). The intention is to quickly flow the change into our optimization repo, then collect and ingest the new data so we can turn optimization back on.

This issue tracks turning PGO optimization back on.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 12, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

#84148 turns off PGO optimization because it was hitting a compiler crash when consuming and old version of profile data produced by clang9 instrumented builds (https://bugzilla.redhat.com/show_bug.cgi?id=1827282). The intention is to quickly flow the change into our optimization repo, then collect and ingest the new data so we can turn optimization back on.

This issue tracks turning PGO optimization back on.

Author: sbomer
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@sbomer sbomer mentioned this issue Apr 12, 2023
Merged
@sbomer sbomer self-assigned this Apr 12, 2023
@jkotas jkotas added area-Infrastructure-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 13, 2023
@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

#84148 turns off PGO optimization because it was hitting a compiler crash when consuming and old version of profile data produced by clang9 instrumented builds (https://bugzilla.redhat.com/show_bug.cgi?id=1827282). The intention is to quickly flow the change into our optimization repo, then collect and ingest the new data so we can turn optimization back on.

This issue tracks turning PGO optimization back on.

Author: sbomer
Assignees: sbomer
Labels:

area-CodeGen-coreclr, area-Infrastructure-coreclr, untriaged
Milestone: -

@sbomer
Copy link
Member Author

sbomer commented Apr 21, 2023 •
edited
Loading

Currently blocked by #84635 #85193

@sbomer sbomer mentioned this issue Apr 25, 2023
Merged
sbomer added a commit that referenced this issue Apr 25, 2023
@sbomer
Fix Avx2 helpers (#85275)
8e01ad8 
Unblocks dotnet-optimization flow and
#84711. Includes a
dotnet-optimization update to confirm this it avoids the issue
discussed in #84635. This
fixes that issue by preventing R2R for any Avx2 helpers which
assume they are called with Avx2 enabled.
@sbomer sbomer mentioned this issue Apr 25, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 25, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Apr 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbomer sbomer

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable PGO for linux sbomer/runtime
2 participants
@sbomer @jkotas