Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetILFunctionBody fails in dotnet 7 for dynamic methods with CORPROF_E_DATAINCOMPLETE #86577

Closed
AllenBiton opened this issue May 21, 2023 · 4 comments · Fixed by #87530
Closed

GetILFunctionBody fails in dotnet 7 for dynamic methods with CORPROF_E_DATAINCOMPLETE #86577

AllenBiton opened this issue May 21, 2023 · 4 comments · Fixed by #87530
Assignees
@davmason
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Milestone
8.0.0

Comments

@AllenBiton
Copy link

AllenBiton commented May 21, 2023 •
edited
Loading

dotnet 7 removed the feature to GetILFunctionBody of dynamic methods.
This is needed for code coverage for example and faking and more.
Please bring this feature back or give us a workaround to do this so we dynamically change the code with unmanaged API.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 21, 2023
@AllenBiton AllenBiton changed the title Running a unit test that tests the creation of a dynamic assembly+module+type+Interface+method with our profiler enabled is failing GetILFunctionBody fails in dotnet 7 for dynamic methods with CORPROF_E_DATAINCOMPLETE May 21, 2023
@vitek-karas vitek-karas transferred this issue from dotnet/sdk May 22, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 22, 2023
@ghost
Copy link

ghost commented May 22, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet 7 removed the feature to GetILFunctionBody of dynamic methods.
This is needed for code coverage for example and faking and more.
Please bring this feature back or give us a workaround to do this so we dynamically change the code with unmanaged API.

Author: AllenBiton
Assignees: -
Labels:

area-Diagnostics-coreclr, untriaged, needs-area-label
Milestone: -

@hoyosjs hoyosjs removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 22, 2023
@hoyosjs
Copy link
Member

hoyosjs commented May 22, 2023

cc: @davmason

@davmason
Copy link
Member

Hi @AllenBiton, thanks for filing this issue. Would you be able to test a private runtime to see if it fixes your issue? I can provide you with binaries or link to a github repository where you can build them yourself.

This commit should fix your issue davmason@930b0cb

@tommcdon tommcdon added this to the 8.0.0 milestone May 23, 2023
@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label May 23, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 23, 2023
@davmason
Copy link
Member

To update this thread, @AllenBiton and I are chatting privately and he is testing a private build to see if it fixes the issue

@davmason davmason mentioned this issue Jun 13, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 13, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davmason davmason

Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix GetILFunctionBody for dynamic methods davmason/runtime
5 participants
@jeffschwMSFT @davmason @tommcdon @hoyosjs @AllenBiton