Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetILFunctionBody for dynamic methods #87530

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

davmason
Copy link
Member

Fixes #86577

Fixes a regression introduced in 7.0 from #59590.

Dynamic modules do not have a PE Image so would fail the check, but we can still get IL from a dynamic module.

@davmason davmason added this to the 8.0.0 milestone Jun 13, 2023
@davmason davmason requested a review from a team June 13, 2023 21:57
@davmason davmason self-assigned this Jun 13, 2023
@ghost
Copy link

ghost commented Jun 13, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86577

Fixes a regression introduced in 7.0 from #59590.

Dynamic modules do not have a PE Image so would fail the check, but we can still get IL from a dynamic module.

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr

Milestone: 8.0.0

@davmason davmason merged commit e082cc6 into dotnet:main Jun 14, 2023
davmason added a commit to davmason/runtime that referenced this pull request Jun 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetILFunctionBody fails in dotnet 7 for dynamic methods with CORPROF_E_DATAINCOMPLETE
2 participants