Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][blazor] Unexpected files in publish folder #88142

Closed
pavelsavara opened this issue Jun 28, 2023 · 4 comments · Fixed by #89079
Closed

[browser][blazor] Unexpected files in publish folder #88142

pavelsavara opened this issue Jun 28, 2023 · 4 comments · Fixed by #89079
Assignees
@maraf
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
8.0.0

Comments

@pavelsavara
Copy link
Member

  • nuget.config from the directory of the .csproj
  • dotnet.native.wasm from runtime pack
    appear in the bin\Release\net8.0\publish\ output folder after dotnet publish with AOT rebuild.

binlog attached

image

msbuild.binlog.zip

cc @maraf @radical
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono labels Jun 28, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • nuget.config from the directory of the .csproj
  • dotnet.native.wasm from runtime pack
    appear in the bin\Release\net8.0\publish\ output folder after dotnet publish with AOT rebuild.

binlog attached

image

msbuild.binlog.zip

cc @maraf @radical

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: 8.0.0

@maraf maraf self-assigned this Jun 28, 2023
@radical
Copy link
Member

radical commented Jun 28, 2023

nuget.config is very odd!

@radical
Copy link
Member

radical commented Jun 28, 2023

Hm it's getting picked up as a default Content item, IIUC.

@maraf maraf mentioned this issue Jul 17, 2023
Closed
@maraf
Copy link
Member

maraf commented Jul 18, 2023 •
edited
Loading

The dotnet.native.wasm comes from runtime pack and should have been replaced (and moved wwwroot) by AOTed version, but the ComputeWasmPublishAssets didn't push it to the FilesToRemove

@maraf maraf mentioned this issue Jul 18, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 18, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 18, 2023
@pavelsavara pavelsavara mentioned this issue Jul 28, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[browser] Fix treating dotnet.native.wasm as native asset during publish maraf/runtime
3 participants
@radical @pavelsavara @maraf