Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Fix treating dotnet.native.wasm as native asset during publish #89079

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[browser] Fix treating dotnet.native.wasm as native asset during publish #89079

merged 1 commit into from
Jul 18, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Jul 18, 2023

  • Regression from adding support for webcil
  • Webcil extension and wasm/native asset extension now match

Fixes #88142

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jul 18, 2023
@maraf maraf added this to the 8.0.0 milestone Jul 18, 2023
@maraf maraf requested review from radical and lambdageek July 18, 2023 13:07
@maraf maraf self-assigned this Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Regression from adding support for webcil
  • Webcil extension and wasm/native asset extension now match

Fixes #88142

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono, os-browser
Milestone: 8.0.0

@radical
Copy link
Member

radical commented Jul 18, 2023

Does this need a corresponding PR in sdk to update baselines?

@maraf
Copy link
Member Author

maraf commented Jul 18, 2023

Does this need a corresponding PR in sdk to update baselines?

No and it's sad that SDK tests didn't found it.

@radical
Copy link
Member

radical commented Jul 18, 2023

Does this need a corresponding PR in sdk to update baselines?

No and it's sad that SDK tests didn't found it.

So the baselines in the sdk check for everything under wwwroot?

@maraf
Copy link
Member Author

maraf commented Jul 18, 2023

Does this need a corresponding PR in sdk to update baselines?

No and it's sad that SDK tests didn't found it.

So the baselines in the sdk check for everything under wwwroot?

Seems like it https://github.com/dotnet/sdk/blob/638fd1e35ec640883aa2aaf36752610e54944c53/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs#L114C23-L114C23

@radical
Copy link
Member

radical commented Jul 18, 2023

Maybe we should add a test in sdk to check for a clean publish folder? Just a specific test.

@maraf maraf merged commit cdff572 into dotnet:main Jul 18, 2023
26 checks passed
@maraf maraf deleted the WasmDotnetWasmInPublish branch July 18, 2023 17:02
@maraf maraf mentioned this pull request Jul 21, 2023
Closed
1 task
@pavelsavara pavelsavara mentioned this pull request Jul 28, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@radical radical Awaiting requested review from radical

@lambdageek lambdageek Awaiting requested review from lambdageek

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[browser][blazor] Unexpected files in publish folder
3 participants
@maraf @radical @lewing