Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Tests failing System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.* due to Specified type is not supported #88983

Closed
ivanpovazan opened this issue Jul 17, 2023 · 4 comments · Fixed by #90023
Closed

[mono] Tests failing System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.* due to Specified type is not supported #88983

ivanpovazan opened this issue Jul 17, 2023 · 4 comments · Fixed by #90023
Assignees
@ivanpovazan
Labels
area-Codegen-Intrinsics-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Milestone
8.0.0

Comments

@ivanpovazan
Copy link
Member

ivanpovazan commented Jul 17, 2023 •
edited by build-analysis bot
Loading

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=341298

Affected pipelines:

  • runtime-extra-platforms

Build error legs:

  • net8.0-windows-Release-x64-Mono_Release-Windows.11.Amd64.Client.Open
  • net8.0-windows-Release-x64-Mono_Release-Windows.Amd64.Server2022.Open
  • net8.0-windows-Release-x64-Mono_Release-Windows.81.Amd64.Open

Tests failing:

  • System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.*

Pull request: #88723

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorPattern": "System\\.Runtime\\.Intrinsics\\.Tests\\.Vectors\\.Vector128Tests\\.\\w+\\s\\[FAIL\\]",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=341298
Error message validated: System\.Runtime\.Intrinsics\.Tests\.Vectors\.Vector128Tests\.\w+\s\[FAIL\]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/17/2023 8:15:44 AM UTC

Report

Build Definition Test Pull Request
372550 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
372445 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #90270
372307 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
372186 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntShiftLeftTest
372071 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
371811 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedTest
371518 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntShiftRightLogicalTest
371313 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #90413
370857 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
370244 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
369565 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #90304
369870 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89712
369604 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #90150
369496 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
369482 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #90298
369160 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #90199
368974 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntShiftLeftTest #90119
368875 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest
368230 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntShiftRightLogicalTest #90184
368204 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest #90225
367894 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #90150
367870 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
367380 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
367235 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest #90119
366678 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest #89997
366629 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #87108
366404 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntShiftLeftTest
365849 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest
365172 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntShiftRightLogicalTest
364942 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
364831 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
364732 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntShiftRightLogicalTest
364492 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
364028 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
363818 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest #87108
363584 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest #89997
363283 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
362691 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
362632 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89966
362128 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntStoreUnsafeIndexTest #89813
361950 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest #89421
361849 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
361682 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest #89421
361365 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89809
361283 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntShiftLeftTest
360331 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntStoreAlignedTest
360323 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89726
359818 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest #89809
359789 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89813
359654 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
359427 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89260
358612 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
358004 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
357256 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntShiftRightArithmeticTest #89421
357141 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.IsSupportedUInt64
357013 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89421
356877 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntStoreAlignedNonTemporalTest
356640 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntShiftLeftTest
356525 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest
356351 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89638
356170 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest
355784 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
355019 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
354414 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
353999 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89569
353633 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
353096 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
353048 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89467
352690 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadUnsafeTest #89431
352553 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89498
352326 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
351937 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
351866 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
351758 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89223
351723 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest
351065 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
351063 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.IsSupportedSByte #89421
350917 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest #89308
350495 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
350271 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest
349510 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
349328 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.IsSupportedUIntPtr
349156 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
349045 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
348654 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntShiftRightLogicalTest
348291 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
347426 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
346915 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreTest
346860 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
346590 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89260
346479 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
346114 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntLoadUnsafeIndexTest
345752 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
345634 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NUIntShiftRightLogicalTest
345419 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
345080 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #89187
344997 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntStoreAlignedNonTemporalTest
344698 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntShiftRightArithmeticTest
344129 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest
343954 dotnet/runtime System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.Vector128NIntLoadAlignedNonTemporalTest #88723
Displaying 100 of 107 results

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
3 28 107
@ivanpovazan ivanpovazan added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab area-Codegen-Intrinsics-mono labels Jul 17, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 17, 2023
@ivanpovazan
Copy link
Member Author

Hey @fanyang-mono could this #88101 be related to the failing tests?

@ivanpovazan ivanpovazan added this to the 8.0.0 milestone Jul 17, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 17, 2023
@fanyang-mono
Copy link
Member

No, it shouldn't be. That PR changed the behavior of SpanHelpers, not Vector128 itself.

@fanyang-mono
Copy link
Member

Are they only failing on windows?

@ivanpovazan ivanpovazan mentioned this issue Jul 19, 2023
Merged
@ivanpovazan
Copy link
Member Author

@vargaz I have verified that the regressions on win-x64 started occurring with: ac2d3fb

The problem seems to be related to the change on this line: ac2d3fb#diff-012b47a27abc5dbc9d2a0b6fdef4adec27fa207a7d2b53823a8bc80f6539f5afR2384
which changed the behaviour of Vector128<T>.IsSupported intrinsic on win-x64 platforms to always return false even for supported type parameters used with generic Vector128.

There are two groups of tests failing because of this:

  • all IsSupported tests returning false, for otherwise supported type parameter types
  • all tests relying on .AsNInt() or .AsNUInt() throwing System.NotSupportedException: Specified type is not supported because internally these extension methods call

    runtime/src/libraries/System.Private.CoreLib/src/System/ThrowHelper.cs

    Lines 732 to 734 in d56723b

    internal static void ThrowForUnsupportedIntrinsicsVector128BaseType<T>()
    {
    if (!Vector128<T>.IsSupported)

@ivanpovazan ivanpovazan mentioned this issue Aug 4, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2023
@ivanpovazan ivanpovazan self-assigned this Aug 7, 2023
ivanpovazan added a commit that referenced this issue Aug 14, 2023
@ivanpovazan @lewing
[mono] Fix Vector<T>.IsSupported intrinsic (#90023)
715086f 
Fixes #88983
---------

Co-authored-by: Larry Ewing <[email protected]>
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ivanpovazan ivanpovazan

Labels
area-Codegen-Intrinsics-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[mono] Fix Vector<T>.IsSupported intrinsic ivanpovazan/runtime
2 participants
@fanyang-mono @ivanpovazan