Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed 'hwintrinsicChild->isContained()' #90508

Closed
EgorBo opened this issue Aug 14, 2023 · 4 comments · Fixed by #90556
Closed

Assertion failed 'hwintrinsicChild->isContained()' #90508

EgorBo opened this issue Aug 14, 2023 · 4 comments · Fixed by #90556
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@EgorBo
Copy link
Member

EgorBo commented Aug 14, 2023

using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;

public class Tests
{
    public static void Main()
    {
        Div(default, 1);
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    static Vector128<double> Div(Vector128<double> v, double b) => v / b;
}

Fails on Checked, win-x64, Tier0 with:

Assert failure(PID 48468 [0x0000bd54], Thread: 44484 [0xadc4]): Assertion failed 'hwintrinsicChild->isContained()' in 'mytest:Foo(System.Runtime.Intrinsics.Vector128`1[double],double):System.Runtime.Intrinsics.Vector128`1[double]' during 'Generate code' (IL size 8; hash 0xece1a119; Tier0)

    File: C:\prj\runtime-main\src\coreclr\jit\instr.cpp Line: 858
    Image: C:\prj\runtime-main\artifacts\bin\coreclr\windows.x64.Checked\CoreRun.exe
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 14, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 14, 2023
@ghost
Copy link

ghost commented Aug 14, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
using System.Runtime.CompilerServices;
using System.Runtime.Intrinsics;

public class Tests
{
    public static void Main()
    {
        Div(default, 1);
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    static Vector128<double> Div(Vector128<double> v, double b) => v / b;
}

Fails with:

Assert failure(PID 48468 [0x0000bd54], Thread: 44484 [0xadc4]): Assertion failed 'hwintrinsicChild->isContained()' in 'mytest:Foo(System.Runtime.Intrinsics.Vector128`1[double],double):System.Runtime.Intrinsics.Vector128`1[double]' during 'Generate code' (IL size 8; hash 0xece1a119; Tier0)

    File: C:\prj\runtime-main\src\coreclr\jit\instr.cpp Line: 858
    Image: C:\prj\runtime-main\artifacts\bin\coreclr\windows.x64.Checked\CoreRun.exe
Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@EgorBo EgorBo added this to the 8.0.0 milestone Aug 14, 2023
@EgorBo EgorBo removed the untriaged New issue has not been triaged by the area owner label Aug 14, 2023
@JulieLeeMSFT JulieLeeMSFT assigned jakobbotsch and unassigned EgorBo Aug 31, 2023
@JulieLeeMSFT
Copy link
Member

Reassigning to @jakobbotsch, PTAL.

@kunalspathak
Copy link
Member

@EgorBo - I don't see this failure on latest main. Can you confirm if it still repros for you? Also, seems the error message and the test case doesn't match. The error message has Foo in it which I presume is Div in your example.

@EgorBo
Copy link
Member Author

EgorBo commented Sep 18, 2023

@EgorBo - I don't see this failure on latest main. Can you confirm if it still repros for you? Also, seems the error message and the test case doesn't match. The error message has Foo in it which I presume is Div in your example.

I think it still repros, you just need Avx512 for that (because it has the containable broadcasts)

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 26, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants