Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hwintrinsicChild->isContained() assert #90556

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Fix hwintrinsicChild->isContained() assert #90556

merged 10 commits into from
Oct 4, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 14, 2023 •
edited
Loading

Fixes #90508

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 14, 2023
@ghost ghost assigned EgorBo Aug 14, 2023
@ghost
Copy link

ghost commented Aug 14, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Aug 15, 2023
Closed
@EgorBo EgorBo marked this pull request as ready for review August 15, 2023 18:04
This was referenced Aug 15, 2023
Closed
Closed
Open
@kunalspathak
Copy link
Member

are you still working on this @EgorBo ?

@BruceForstall
Copy link
Member

are you still working on this @EgorBo ?

If not, please make it "Draft"

@EgorBo
Copy link
Member Author

EgorBo commented Sep 18, 2023

Oops, didn't get notifications for this one -- yes, I'll finish it this week, fixes #90508

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Sep 20, 2023
@EgorBo EgorBo closed this Sep 26, 2023
@EgorBo EgorBo reopened this Sep 26, 2023
@JulieLeeMSFT
Copy link
Member

@EgorBo, I reran the failed tests and it alls passed. Is it ready to merge?

@EgorBo
Copy link
Member Author

EgorBo commented Oct 2, 2023

Should be ready now, waiting for spmi diffs

@EgorBo
Copy link
Member Author

EgorBo commented Oct 3, 2023 •
edited
Loading

@dotnet/jit-contrib PTAL, a fix for a containment bug (it used to "contain" some nodes such as locals while we can only contain constants and memory loads)

kunalspathak
kunalspathak reviewed Oct 3, 2023
View reviewed changes
src/tests/JIT/Regression/JitBlue/Runtime_90508/Runtime_90508.cs Outdated
v + Sse3.MoveAndDuplicate(Vector128.CreateScalarUnsafe(b));

[MethodImpl(MethodImplOptions.NoInlining)]
private static Vector128<double> Test2(Vector128<double> v, double b) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: b in Test2 and Test3 are unused.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, indeed, fixed!

kunalspathak
kunalspathak approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorBo EgorBo merged commit bb32921 into dotnet:main Oct 4, 2023
135 of 138 checks passed
@build-analysis build-analysis bot mentioned this pull request Oct 5, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2023
@EgorBo EgorBo mentioned this pull request Jan 1, 2024
Closed
@EgorBo
Copy link
Member Author

EgorBo commented Jan 1, 2024

/backport to release/8.0-staging

@github-actions github-actions bot unlocked this conversation Jan 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7380228196

@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall left review comments

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Assertion failed 'hwintrinsicChild->isContained()'
4 participants
@EgorBo @kunalspathak @BruceForstall @JulieLeeMSFT