Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.NET.CrossGen.targets: stop using legacy runtime graph #90977

Closed
tmds opened this issue Aug 23, 2023 · 4 comments · Fixed by #91077
Closed

Microsoft.NET.CrossGen.targets: stop using legacy runtime graph #90977

tmds opened this issue Aug 23, 2023 · 4 comments · Fixed by #91077
Labels
area-crossgen2-coreclr
Milestone
8.0.0

Comments

@tmds
Copy link
Member

tmds commented Aug 23, 2023

The .NET 8 SDK is using the new trimmed graph by default, with the exception of Microsoft.NET.CrossGen.targets which is still using the legacy graph.

runtime/src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets

Line 446 in 7881fe3

RuntimeGraphPath="$(BundledRuntimeIdentifierGraphFile)"

Relates to #90000.

cc @elinor-fung @dsplaisted @ViktorHofer
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 23, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 23, 2023
@ViktorHofer ViktorHofer added area-crossgen2-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 23, 2023
@ViktorHofer ViktorHofer added this to the 8.0.0 milestone Aug 23, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 23, 2023
@ViktorHofer
Copy link
Member

@elinor-fung I marked this as 8.0 for now. Please take a look.

@elinor-fung
Copy link
Member

I think we want BundledRuntimeIdentifierGraphFile -> RuntimeIdentifierGraphPath to match the change @dsplaisted made for the shipping target in sdk: https://github.com/dotnet/sdk/blob/main/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets#L447

@elinor-fung
Copy link
Member

Actually, I don't think we can do that until runtime moves to using an SDK that has the trimmed graph (RC1).

@ViktorHofer
Copy link
Member

You could the following meanwhile:

$([MSBuild]::ValueOrDefault('$(RuntimeIdentifierGraphPath)', '$(BundledRuntimeIdentifierGraphFile)'))

So it reads from the first property and only if that one isn't set, read from the legacy one.

@elinor-fung elinor-fung mentioned this issue Aug 24, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2023
@elinor-fung elinor-fung mentioned this issue Aug 24, 2023
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Aug 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
8.0.0
3 participants
@tmds @ViktorHofer @elinor-fung