Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Use RuntimeIdentifierGraphPath if available in runtime copy of Microsoft.NET.CrossGen.targets #91090

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 24, 2023

Backport of #91077 to release/8.0

Fixes #90977

/cc @elinor-fung

Customer Impact

This is a non-shipping target used by the runtime repo.

The sdk (shipping) version of this target was updated to use the new trimmed graph as part of dotnet/sdk#34279. This makes the equivalent change here such that it uses the RuntimeIdentifierGraphPath if set (SDK always sets starting with .NET 8 RC1), otherwise BundledRuntimeIdentifierGraphFile.

Testing

Local and CI build

Risk

Low

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 24, 2023
@elinor-fung elinor-fung added Servicing-consider Issue for next servicing release review and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 24, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. once ready this can be merged.

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release area-crossgen2-coreclr and removed Servicing-consider Issue for next servicing release review labels Aug 24, 2023
@jeffschwMSFT jeffschwMSFT added this to the 8.0.0 milestone Aug 24, 2023
@carlossanlop carlossanlop merged commit d379e3a into release/8.0 Aug 25, 2023
183 of 187 checks passed
@carlossanlop carlossanlop deleted the backport/pr-91077-to-release/8.0 branch August 25, 2023 22:11
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-crossgen2-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants