-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional in HttpConnection.cs seems redundant? #94261
Comments
Tagging subscribers to this area: @dotnet/ncl Issue Detailsruntime/src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Lines 519 to 533 in 7e316e2
The same code is executed if the conditional is true or false. Is the conditional supposed to do something different?
|
This code originally came from Mono, and history in this repo has those two blocks always being the same; looking in mono/mono, it goes back upwards of 15 years, and arrived like this after multiple refactorings. I'm not sure what the original intent was, but we can delete the duplication now. |
Would you like to submit a PR @omajid? From triage perspective, putting it to Future. We would welcome the contribution. Thanks! |
The code does the same thing whether the conditional is true or false, so remove the conditional. Also remove the now-unused `_chuncked` field. Fixes: dotnet#94261
The code does the same thing whether the conditional is true or false, so remove the conditional. Also remove the now-unused `_chuncked` field. Fixes: #94261
runtime/src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs
Lines 519 to 533 in 7e316e2
The same code is executed if the conditional is true or false. Is the conditional supposed to do something different?
The text was updated successfully, but these errors were encountered: