Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed '!"Extra flags on tree"' #99929

Closed
BruceForstall opened this issue Mar 18, 2024 · 3 comments · Fixed by #100005
Closed

Assertion failed '!"Extra flags on tree"' #99929

BruceForstall opened this issue Mar 18, 2024 · 3 comments · Fixed by #100005
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes os-windows
Milestone

Comments

@BruceForstall
Copy link
Member

runtime-coreclr jitstress-random

coreclr windows x64 Checked jitstress_random_2 @ Windows.10.Amd64.Open

JIT.performance Work Item

https://dev.azure.com/dnceng-public/public/_build/results?buildId=607041&view=ms.vss-test-web.build-test-results-tab

set DOTNET_TieredCompilation=0
set DOTNET_JitStress=1ef


19:41:08.655 Running test: JIT/Performance/CodeQuality/HWIntrinsic/X86/PacketTracer/PacketTracer/PacketTracer.dll
Extra flags on tree [002332]: -CX-------
N009 ( 10, 16) [002332] -ACXG------                         *  COMMA     simd32 <l:$427, c:$784>
N006 (  5, 12) [002330] DA--G------                         +--*  STORE_LCL_VAR simd32 V284 cse7        d:1 $VN.Void
N005 (  5, 12) [000973] I---G------                         |  \--*  IND       simd32 <l:$427, c:$784>
N004 (  3, 10) [000972] H----------                         |     \--*  CNS_INT(h) long   0x24119aa6340 static Fseq[Ox7] $51
N008 (  5,  4) [002454] DA--G------                         \--*  STORE_LCL_VAR simd32 V319 rat34       
N007 (  1,  1) [002331] -----------                            \--*  LCL_VAR   simd32 V284 cse7        u:1 <l:$427, c:$784>

Assert failure(PID 3812 [0x00000ee4], Thread: 5200 [0x1450]): Assertion failed '!"Extra flags on tree"' in 'Packet256Tracer:GetNaturalColor(System.Runtime.Intrinsics.Vector256`1[int],VectorPacket256,VectorPacket256,VectorPacket256,Scene):VectorPacket256:this' during 'Stress gtSplitTree' (IL size 820; hash 0xcc7cbf41; FullOpts)

    File: D:\a\_work\1\s\src\coreclr\jit\fgdiagnostic.cpp:3598
    Image: C:\h\w\9723085D\p\corerun.exe

App Exit Code: -1073740286

@dotnet/jit-contrib

@BruceForstall BruceForstall added os-windows JitStress CLR JIT issues involving JIT internal stress modes arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs labels Mar 18, 2024
@BruceForstall BruceForstall added this to the 9.0.0 milestone Mar 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch
Copy link
Member

I'll take a look.

@jakobbotsch jakobbotsch self-assigned this Mar 19, 2024
@EgorBo
Copy link
Member

EgorBo commented Mar 19, 2024

My bet that assertprop propagates a constant and doesn't update flags in the parent node(s)

jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Mar 20, 2024
When we sink a store below a comma, we should update the comma's flags
after updating the flags of the store, not before.

Fix dotnet#99929
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Mar 20, 2024
When we sink a store below a comma, we should update the comma's flags
after updating the flags of the store, not before.

Fix dotnet#99929
jakobbotsch added a commit that referenced this issue Mar 20, 2024
When we sink a store below a comma, we should update the comma's flags
after updating the flags of the store, not before.

Fix #99929
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes os-windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants