Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax for PC relative offsets in ARM assembly #100066

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Mar 21, 2024

Fixes #100047

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 21, 2024
@filipnavara filipnavara changed the title CI test, please ignore Update syntax for PC relative offsets in ARM assembly Mar 21, 2024
@filipnavara filipnavara marked this pull request as ready for review March 21, 2024 10:31
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jkotas
Copy link
Member

jkotas commented Mar 21, 2024

/ba-g I have filled a new issue on a failure unrelated to the PR (#100088), the issue was matched against the failure, but the Build Analysis is not turning green even after multiple reruns.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit cfe3d2d into dotnet:main Mar 21, 2024
88 of 92 checks passed
@filipnavara filipnavara deleted the patch-17 branch March 21, 2024 16:55
@carlossanlop
Copy link
Member

This is blocking the build in the preview3 freshly-snapped branch. I'll backport this.

@carlossanlop
Copy link
Member

/backport to release/9.0-preview3

Copy link
Contributor

Started backporting to release/9.0-preview3: https://github.com/dotnet/runtime/actions/runs/8393377027

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error: out of range pc-relative fixup value" on linux-armel checked CoreCLR_NonPortable
4 participants