-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-preview3] Revert #99140 #100147
[release/9.0-preview3] Revert #99140 #100147
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Have we verified that this change is actually fixing the issue? |
Nope. we're waiting to hear from Rolf from main, I opened the backport just to make the potential need clear while they test. |
It is no longer crashing in the xamarin-macios codeflow PR: xamarin/xamarin-macios#20343 . |
Filed a proper fix #100206, so I presume we should backport that one, although, this revert is also fine to merge since it fixes the problem too (validated) |
looks like we want to close this PR? |
Like I said - it's ok to merge this if the issue is blocking. |
Backport of #100143 to release/9.0-preview3
/cc @lewing @EgorBo
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.