Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RhpLockCmpXchg64 FCall on win-x86 #100155

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

filipnavara
Copy link
Member

I broke win-x86 builds with PR #100021 when RhpLockCmpXchg64 was moved to C code. On x86 we need to properly name mangle it and reverse the parameter order.

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Mar 22, 2024

/ba-g Infrastructure timeout (#76454). The affected leg does not exercise the change in meaningful way, no reason for retrying.

@jkotas jkotas merged commit 7005f46 into dotnet:main Mar 22, 2024
87 of 90 checks passed
@filipnavara filipnavara deleted the win-x86-lockcmpxchg64 branch March 23, 2024 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x86 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants