Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Use source built emsdk packages for the runtime build #100266

Merged
merged 47 commits into from
May 9, 2024
Merged

[wasm] Use source built emsdk packages for the runtime build #100266

merged 47 commits into from
May 9, 2024

Commits on Apr 2, 2024

  1. Use the emsdk transport packages to build wasm instead of a cloned emsdk 

    Works for the most part out of the box, but fails on the part where we npm install after
the libraries build. The reason for the failure is our node transport package is incomplete. If
you replace it with a legit node, the build works fully.
    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bf309cf View commit details
    Browse the repository at this point in the history

  2. Pull in node transport package as opposed to the one packaged in emsd… 

    …k. Streamline package deps
    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    411fcb5 View commit details
    Browse the repository at this point in the history

  3. Make paths friendly for windows

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1964d80 View commit details
    Browse the repository at this point in the history

  4. Work in windows transport packages, copy python to its own directory,… 

    … and adjust a bunch of paths
    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b8e1d17 View commit details
    Browse the repository at this point in the history

  5. Bump to latest version of node that contains icu

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    35d78ba View commit details
    Browse the repository at this point in the history

  6. Add windows deps and add DOTNET_EMSCRIPTEN_NODE_PATH because windows … 

    …can't see npm without it
    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    86b0487 View commit details
    Browse the repository at this point in the history

  7. Bump emscripten packages to the latest

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bad7dd2 View commit details
    Browse the repository at this point in the history

  8. Fix typos in Version.Details.xml

    @akoeplinger @steveisok
    akoeplinger authored and steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e2de97e View commit details
    Browse the repository at this point in the history

  9. Switch out to the plain mariner container to ensure no EMSDK already … 

    …exists
    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    70cc1ef View commit details
    Browse the repository at this point in the history

  10. Revert back to the browser-wasm docker image and bump to the latest

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b73b48c View commit details
    Browse the repository at this point in the history

  11. Container type-o

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    ebcbd2c View commit details
    Browse the repository at this point in the history

  12. Fix condition where the node path isn't set properly

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    107934a View commit details
    Browse the repository at this point in the history

  13. Provision even when building offsets

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    cd1b7e6 View commit details
    Browse the repository at this point in the history

  14. Fix goofy paths

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d912622 View commit details
    Browse the repository at this point in the history

  15. Update new template to use the latest browser-wasm container

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    7b5f544 View commit details
    Browse the repository at this point in the history

  16. Don't put python.exe on the path for windows, but the folder instead

    @steveisok
    steveisok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    58a4164 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. So that was a bad idea. May have to have emsdk_env.cmd have two entries

    @steveisok
    steveisok committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d4e980e View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Fix offsets generation for browser

    @radekdoulik
    radekdoulik committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f3aad8a View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Fix emsdk's python path 

    It is not versioned anymore as we use the content of our nugets
    @radekdoulik
    radekdoulik committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    47b2f73 View commit details
    Browse the repository at this point in the history

  2. Fix EMSDK_PATH on non-windows platforms

    @radekdoulik
    radekdoulik committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d19b395 View commit details
    Browse the repository at this point in the history

  3. Do not add link flags to compile flags 

    To avoid:

    C:\helix\work\correlation\build\wasm-shared\WasmApp.Common.targets(825,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_ES6' [-Wunused-command-line-argument] [C:\helix\work\workitem\e\publish\ProxyProjectForAOTOnHelix.proj]
    C:\helix\work\correlation\build\wasm-shared\WasmApp.Common.targets(825,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_EXCEPTION_HANDLING_HELPERS' [-Wunused-command-line-argument] [C:\helix\work\workitem\e\publish\ProxyProjectForAOTOnHelix.proj]
    @radekdoulik
    radekdoulik committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    eb19ade View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Set the emsdk paths relative to the script location

    @radekdoulik
    radekdoulik committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    16043ad View commit details
    Browse the repository at this point in the history

  2. Escape few characters and fix the added script

    @radekdoulik
    radekdoulik committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    64453f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Fix .emscripten script

    @radekdoulik
    radekdoulik committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ba83f8e View commit details
    Browse the repository at this point in the history

  2. Use EM_CONFIG intead of __file__

    @radekdoulik
    radekdoulik committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d26a6ec View commit details
    Browse the repository at this point in the history

  3. Fix emsdk_env.cmd script

    @radekdoulik
    radekdoulik committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f456ba5 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Revert "Do not add link flags to compile flags" 

    This reverts commit eb19ade.
    @radekdoulik
    radekdoulik committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4ce27ec View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'remotes/origin/main' into test-build-wasm

    @radekdoulik
    radekdoulik committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ba2e34f View commit details
    Browse the repository at this point in the history

  3. Revert changes in package-lock.json

    @radekdoulik
    radekdoulik committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e1a7372 View commit details
    Browse the repository at this point in the history

  4. Feedback + cleaning

    @radekdoulik
    radekdoulik committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3c17d1f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into test-build-wasm

    @radekdoulik
    radekdoulik committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b417733 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. More cleaning

    @radekdoulik
    radekdoulik committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a62a857 View commit details
    Browse the repository at this point in the history

  2. Try not to use the replace in the EMSDK_PATH

    @radekdoulik
    radekdoulik committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    667eaf5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into test-build-wasm

    @radekdoulik
    radekdoulik committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6d3514a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Better property names

    @radekdoulik
    radekdoulik committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    278fbd7 View commit details
    Browse the repository at this point in the history

  2. Use package and emsdk version properties 

    Co-authored-by: Larry Ewing <[email protected]>
    @radekdoulik @lewing
    radekdoulik and lewing committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b25fbd6 View commit details
    Browse the repository at this point in the history

  3. Use the updated properties

    @radekdoulik
    radekdoulik committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0fc71cf View commit details
    Browse the repository at this point in the history

  4. Fix emsdk version

    @radekdoulik
    radekdoulik committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8a71663 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'main' into test-build-wasm

    @radekdoulik
    radekdoulik committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    afe1b08 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into test-build-wasm

    @radekdoulik
    radekdoulik committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1d4b923 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into test-build-wasm

    @lewing
    lewing committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b46a6a9 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Merge branch 'main' into test-build-wasm

    @radekdoulik
    radekdoulik committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e976299 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Use a single version of emsdk and take node version from flow

    @lewing
    lewing committed May 7, 2024
    Configuration menu
    Copy the full SHA
    48b0006 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into test-build-wasm

    @lewing
    lewing committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6513926 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into test-build-wasm

    @lewing
    lewing committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8672523 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Update eng/Version.Details.xml 

    Co-authored-by: Larry Ewing <[email protected]>
    @radekdoulik @lewing
    radekdoulik and lewing committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7c1b7c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into test-build-wasm

    @radekdoulik
    radekdoulik committed May 9, 2024
    Configuration menu
    Copy the full SHA
    543fe48 View commit details
    Browse the repository at this point in the history