Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Apply eslint formatting in JS/TS #100271

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Mar 26, 2024

Apply formatting to all js/ts files. It prevents other PRs from having non-related changes, e.g. like #100233.

FYI:
There's no rule that would make empty space between function and the bracket, there is an uniform rule making spaces before brackets, including
export async function instantiate_segmentation_rules_asset(pendingAsset: AssetEntryInternal): Promise<void> ->
export async function instantiate_segmentation_rules_asset (pendingAsset: AssetEntryInternal): Promise<void>.

@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Mar 26, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 26, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member

pavelsavara commented Mar 26, 2024

Let's make the npm run lint in the CI fail also on all the white-space problems you discovered. Otherwise we will have the same drift soon again.

@maraf
Copy link
Member

maraf commented Mar 26, 2024

Let's make the npm run lint in the CI fail also on all the white-space problems you discovered. Otherwise we will have the same drift soon again.

It can be part of browser.proj

@pavelsavara
Copy link
Member

Let's make the npm run lint in the CI fail also on all the white-space problems you discovered. Otherwise we will have the same drift soon again.

It can be part of browser.proj

It's already there but it doesn't fail for rules which are not explicitly error severity. Which is most of the rules we inherited from default preset.

@ilonatommy added few important ones explicitly as a stop-gap here.

@ilonatommy ilonatommy merged commit 3ba9223 into dotnet:main Mar 27, 2024
33 of 36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants