[wasi] Select mono components #100407
Merged
[wasi] Select mono components #100407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit d62a165. # Conflicts: # src/mono/wasi/build/WasiApp.targets
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 8, 2024
Seems like MonoTargets are not packed for lib tests.. Okay, wasi lib tests are running without workload, and so mono targets are not there |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 10, 2024
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
reviewed
Apr 18, 2024
lewing
approved these changes
Apr 18, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Don't link icu for InvariantGlobalization=true * Don't link debugger for publish * Revert "Don't link icu for InvariantGlobalization=true" This reverts commit d62a165. # Conflicts: # src/mono/wasi/build/WasiApp.targets * Drop in-tree setup. Solve the rest of the components * Incorporate WasmDebugLevel * Hook MonoSelectRuntimeComponents. Unify component selection * Fix merge damage * Conditional mono targets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diagnostics_tracingdebuggerandhot_reloadfor publish, use real components for build (aligns with browser debugger support)WasmDebugLevel=1or0Contributes to #96862