Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743

Merged
merged 52 commits into from
Apr 24, 2024
Merged

Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743

merged 52 commits into from
Apr 24, 2024

Commits on Mar 22, 2024

  1. JIT ARM64-SVE: Add Sve.Abs() and Sve.Add() 

    Change-Id: Ie8cfe828595da9a87adbc0857c0c44c0ce12f5b2
    @a74nh
    a74nh committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    0d437e3 View commit details
    Browse the repository at this point in the history

  2. Fix sve scaling in enitIns_R_S/S_R

    @a74nh
    a74nh committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e9fa735 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Revert "Fix sve scaling in enitIns_R_S/S_R" 

    This reverts commit e9fa735.
    @a74nh
    a74nh committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    5acc122 View commit details
    Browse the repository at this point in the history

  2. Fix sve scaling in enitIns_R_S/S_R

    @a74nh
    a74nh committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    15e893d View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Restore testing

    @a74nh
    a74nh committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    c22f458 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Use NaturalScale_helper for vector load/stores

    @a74nh
    a74nh committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    508a52a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Merge remote-tracking branch 'origin/main' into api_abs_github

    @kunalspathak
    kunalspathak committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5825c20 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Merge remote-tracking branch 'origin/main' into api_abs_github

    @kunalspathak
    kunalspathak committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9081fa3 View commit details
    Browse the repository at this point in the history

  2. wip

    @kunalspathak
    kunalspathak committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d4f3c86 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Add ConditionalSelect() APIs

    @kunalspathak
    kunalspathak committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    20defbd View commit details
    Browse the repository at this point in the history

  2. Handle ConditionalSelect in JIT

    @kunalspathak
    kunalspathak committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c70367f View commit details
    Browse the repository at this point in the history

  3. Add test coverage

    @kunalspathak
    kunalspathak committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1896b21 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Update the test cases

    @kunalspathak
    kunalspathak committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2e0d022 View commit details
    Browse the repository at this point in the history

  2. jit format

    @kunalspathak
    kunalspathak committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    185fcfa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sve-conditional-select' into abi_abs_conditional

    @kunalspathak
    kunalspathak committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    88e8f87 View commit details
    Browse the repository at this point in the history

  4. fix merge conflicts

    @kunalspathak
    kunalspathak committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ebcb174 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Make predicated/unpredicated work with ConditionalSelect 

    Still some handling around RMW is needed, but this basically works
    @kunalspathak
    kunalspathak committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    28aa7b7 View commit details
    Browse the repository at this point in the history

  2. Misc. changes

    @kunalspathak
    kunalspathak committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    1c7b4b2 View commit details
    Browse the repository at this point in the history

  3. jit format

    @kunalspathak
    kunalspathak committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    6adf6c6 View commit details
    Browse the repository at this point in the history

  4. jit format

    @kunalspathak
    kunalspathak committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    ecf4e01 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into abi_abs_conditional

    @kunalspathak
    kunalspathak committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    c6fef82 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Handle all the conditions correctly

    @kunalspathak
    kunalspathak committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d780156 View commit details
    Browse the repository at this point in the history

  2. jit format

    @kunalspathak
    kunalspathak committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    eb4d1dc View commit details
    Browse the repository at this point in the history

  3. fix some spacing

    @kunalspathak
    kunalspathak committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    00aacab View commit details
    Browse the repository at this point in the history

  4. Removed the assert

    @kunalspathak
    kunalspathak committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f716958 View commit details
    Browse the repository at this point in the history

  5. fix the largest vector size to 64 to fix dotnet#100366

    @kunalspathak
    kunalspathak committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5eadcf9 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. review feedback

    @kunalspathak
    kunalspathak committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    bc6e58d View commit details
    Browse the repository at this point in the history

  2. wip

    @kunalspathak
    kunalspathak committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    19ec4b6 View commit details
    Browse the repository at this point in the history

  3. Add SVE feature detection for Windows

    @kunalspathak
    kunalspathak committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ed7c781 View commit details
    Browse the repository at this point in the history

  4. fix the check for invalid alignment

    @kunalspathak
    kunalspathak committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f966b5e View commit details
    Browse the repository at this point in the history

  5. Revert "Add SVE feature detection for Windows" 

    This reverts commit ed7c781.
    @kunalspathak
    kunalspathak committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f0c81f1 View commit details
    Browse the repository at this point in the history

  6. Handle case where Abs() is wrapped in another conditionalSelect

    @kunalspathak
    kunalspathak committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    89ede7d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. jit format

    @kunalspathak
    kunalspathak committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1f44b2f View commit details
    Browse the repository at this point in the history

  2. fix the size comparison

    @kunalspathak
    kunalspathak committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9712a16 View commit details
    Browse the repository at this point in the history

  3. HW_Flag_MaskedPredicatedOnlyOperation

    @kunalspathak
    kunalspathak committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0ad2e64 View commit details
    Browse the repository at this point in the history

  4. Revert the change in emitarm64.cpp around INS_sve_ldr_mask/INS_sve_st… 

    …r_mask
    @kunalspathak
    kunalspathak committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f76e324 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Fix the condition for lowering

    @kunalspathak
    kunalspathak committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    8af7108 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. address review feedback for movprfx

    @kunalspathak
    kunalspathak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e934e26 View commit details
    Browse the repository at this point in the history

  2. Move the special handling of Vector<>.Zero from lowerer to importer

    @kunalspathak
    kunalspathak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0daeac7 View commit details
    Browse the repository at this point in the history

  3. Rename IsEmbeddedMaskedOperation/IsOptionalEmbeddedMaskedOperation

    @kunalspathak
    kunalspathak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    635a7d7 View commit details
    Browse the repository at this point in the history

  4. Add more test coverage for conditionalSelect

    @kunalspathak
    kunalspathak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    19da982 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Rename test method name

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f1b8b17 View commit details
    Browse the repository at this point in the history

  2. Add more test coverage for conditionalSelect:Abs

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    409a039 View commit details
    Browse the repository at this point in the history

  3. jit format

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0c8a14d View commit details
    Browse the repository at this point in the history

  4. Add logging on test methods

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    53c5eb3 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into abi_abs_conditional

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    868229f View commit details
    Browse the repository at this point in the history

  6. Add the missing movprfx for abs

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9ae3c78 View commit details
    Browse the repository at this point in the history

  7. Add few more scenarios where falseVal is zero

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c8244eb View commit details
    Browse the repository at this point in the history

  8. Make sure LoadVector is marked as explicit needing mask

    @kunalspathak
    kunalspathak committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f6eb1fe View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. revisit the codegen logic

    @kunalspathak
    kunalspathak committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    83e1b1b View commit details
    Browse the repository at this point in the history

  2. Remove commented code and add some other comments

    @kunalspathak
    kunalspathak committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c78e0c7 View commit details
    Browse the repository at this point in the history

  3. jit format

    @kunalspathak
    kunalspathak committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6aa2386 View commit details
    Browse the repository at this point in the history