Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] fix thread creation race with finalizer #100778

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[browser][MT] fix thread creation race with finalizer #100778

merged 1 commit into from
Apr 9, 2024

Conversation

pavelsavara
Copy link
Member

  • initialize mono_wasm_init_finalizer_thread immediately during startup, not lazily
  • make loaderHelpers.loadingWorkers Promise
  • new FinalizerWorks test
  • drop finalizerThreadStartDelayMs
  • drop is_thread_available
  • fix browser-threads sample

@pavelsavara
- intialize mono_wasm_init_finalizer_thread immediately during startu…
ebd014d 
…p, not lazily

- make loaderHelpers.loadingWorkers Promise
- FinalizerWorks test
- drop finalizerThreadStartDelayMs
- drop is_thread_available
- fix browser-threads sample
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Apr 8, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 8, 2024
@pavelsavara pavelsavara self-assigned this Apr 8, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 8, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review April 9, 2024 10:16
@pavelsavara pavelsavara requested a review from lewing as a code owner April 9, 2024 10:16
ilonatommy
ilonatommy approved these changes Apr 9, 2024
View reviewed changes
src/mono/browser/runtime/driver.c Show resolved Hide resolved
src/mono/browser/runtime/pthreads/index.ts Show resolved Hide resolved
@pavelsavara
Copy link
Member Author

/ba-g failures are
#99609
#100275
#100757

@pavelsavara pavelsavara merged commit 4c9db8a into dotnet:main Apr 9, 2024
94 of 98 checks passed
@pavelsavara pavelsavara deleted the browser_mt_fix_worker_preload branch April 9, 2024 10:45
@pavelsavara pavelsavara mentioned this pull request Apr 15, 2024
Closed
31 tasks
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @matouskozak
[browser][MT] fix thread creation race with finalizer (dotnet#100778)
96782df
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @ilonatommy