[mono] simdhash tweaks #101082
Merged
[mono] simdhash tweaks #101082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
kg
added
area-VM-meta-mono
and removed
needs-area-label
This was referenced Apr 16, 2024
…tomatic disadvantage
Remove temporary copies of hash->buffers
…l targets Add FILTER param to benchmark makefile
…conditional returns. This makes find_random much faster and find_missing only slightly slower
Add missing license headers
This was referenced Apr 19, 2024
lambdageek
approved these changes
Apr 19, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Optimize simdhash scalar bucket scan to generate chained cmovs instead of conditional branches, and to skip suffix slots that will always be empty * Optimize temporary copies of hash->buffers out of most simdhash APIs * Build fixes for ght-compatible simdhash * Add missing license headers * Improve simdhash microbenchmark suite and make it compatible with windows x64 MSVC * Use xoshiro256 to generate random values in microbenchmark, with a fixed seed, instead of libc rand * Add filtering support to simdhash microbenchmark makefile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some parts of simdhash, and speeds up scalar suffix search on WASM.