[browser] Fix ConvertDllsToWebCil stack dump on bad input to be error message with input path

[danmoseley]

Fix #101154

It looks like there are no unit tests for this assembly. Should we have them? It is exercised as a whole as part of all the Wasm.Build.Tests.

View diff with whitespace disabled: https://github.com/dotnet/runtime/pull/101162/files?diff=split&w=1

[danmoseley]

Added a basic test. It has to be run manually right now, but it's a start and improvement over none.

[lewing]

The test assemblies are changing the prebuilts

[danmoseley]

The test assemblies are changing the prebuilts

Not sure what that means. Is there an issue with this PR?

[lewing]

The test assemblies are changing the prebuilts

Not sure what that means. Is there an issue with this PR?

I was referring to the failure of runtime-dev-innerloop (Build Source-Build (Linux_x64)) lane.

.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24217.1/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 14 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Castle.Core.5.1.1
Microsoft.CodeCoverage.17.4.0-preview-20220707-01
Microsoft.NET.Test.Sdk.17.4.0-preview-20220707-01
Microsoft.TestPlatform.ObjectModel.17.4.0-preview-20220707-01
Microsoft.TestPlatform.TestHost.17.4.0-preview-20220707-01
Moq.4.18.4
System.Diagnostics.EventLog.6.0.0
xunit.analyzers.1.4.0
xunit.assert.2.6.7-pre.5
xunit.core.2.6.7-pre.5
xunit.extensibility.core.2.6.7-pre.5
xunit.extensibility.execution.2.6.7-pre.5
xunit.runner.console.2.6.7-pre.5
xunit.runner.visualstudio.2.5.7-pre.8

[ViktorHofer]

Please don't check in solution files unless they are necessary.

[danmoseley]

Generally folks will want both tests and impl projects open in VS. what's the recommended way to do that - create a solution manually?

[ViktorHofer]

If we do this, then I would move the src under src/tasks/src same as we do libraries under "src/libraries".

[ViktorHofer]

Because of this, this project gets always built, even in an official build which doesn't run tests. We want to minimize the external dependencies that we restore and use during an official build.

I think tasks.proj should be changed so that task tests are only built when requested.

[danmoseley]

What's the right way to do that?

[ViktorHofer]

You would need to define a new subset in Subsets.props: tasks.tests. Then if that subset is passed in you can pass an additional property to tasks.proj:

runtime/Build.proj

Line 15 in 56ee7c5

<MSBuild Projects="$(RepoTasksDir)tasks.proj"

i.e.

<Properties Condition="...">IncludeTaskTests=true</Properties>

Then in tasks.proj you would change this line:

runtime/src/tasks/tasks.proj

Line 3 in 56ee7c5

<ProjectReference Include="$(MSBuildThisFileDirectory)**\*.csproj" />

to something like

<ProjectReference Include="$(MSBuildThisFileDirectory)**\*.csproj" />
<ProjectReference Remove="$(MSBuildThisFileDirectory)tests\**\*.csproj" Condition="'$(IncludeTaskTests)' != 'true'" />

[ViktorHofer]

We don't have test infrastructure support for tasks. We would need to change Subsets.props and/or YML for that. It might be easier to just move the entire task and the tests under src/libraries.

cc @ericstj @jkoritzinsky @akoeplinger

[radical]

old related issue - #79010

[danmoseley]

I didn't set out to tackle the problem of creating test infrastructure here and probably don't have time. Thoughts about just checking in the fix without the test? Reasoning: none of the others have tests; this test passes when run explicitly.

@lewing ? I can create an issue to create test infra if I do this.

[maraf]

I didn't set out to tackle the problem of creating test infrastructure here and probably don't have time. Thoughts about just checking in the fix without the test? Reasoning: none of the others have tests; this test passes when run explicitly.

I sounds good to me.

[lewing]

I didn't set out to tackle the problem of creating test infrastructure here and probably don't have time. Thoughts about just checking in the fix without the test? Reasoning: none of the others have tests; this test passes when run explicitly.

@lewing ? I can create an issue to create test infra if I do this.

The fix is fine, and while tests for the tasks feel simple sometimes the things that feel simple are actually harder than their benefit.

[danmoseley]

OK, I reverted the tests but left in history in this PR so they can be grabbed in future when someone sets up unit tests for this assembly.

[lewing]

merging main again because this should pass now and I'd like to see the results if it doesn't

[danmoseley]

[03:45:34] info: Starting:    managed/Invariant.Tests.dll
[03:45:34] info: Error: failed to run main module `dotnet.wasm`
[03:45:34] info: 
[03:45:34] info: Caused by:
[03:45:34] info:     0: failed to invoke command default
[03:45:34] info:     1: error while executing at wasm backtrace:
[03:45:34] info:            0: 0x1084b49 - <unknown>!corlib_System_RuntimeType_CreateInstanceImpl_System_Reflection_BindingFlags_System_Reflection_Binder_object___System_Globalization_CultureInfo
[03:45:34] info:            1: 0x11510e7 - <unknown>!corlib_System_Activator_CreateInstance_System_Type_System_Reflection_BindingFlags_System_Reflection_Binder_object___System_Globalization_CultureInfo_object__
[03:45:34] info:            2: 0x11507de - <unknown>!corlib_System_Activator_CreateInstance_System_Type_object__

[lewing]

@ilonatommy please take a look