Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building AppHost in native AOT testing #101270

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

MichalStrehovsky
Copy link
Member

I think this was only needed because the AOT app tests were not doing the right form of publish.

Fixes #79575.

Cc @dotnet/ilc-contrib @eerhardt

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the AOT legs still pass, this change looks reasonable to me.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky MichalStrehovsky merged commit ce63557 into dotnet:main Apr 19, 2024
165 of 173 checks passed
@MichalStrehovsky MichalStrehovsky deleted the noapphost branch April 19, 2024 12:31
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
@ilonatommy
Copy link
Member

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10175899693

@github-actions github-actions bot unlocked this conversation Jul 31, 2024
Copy link
Contributor

@ilonatommy backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Stop building AppHost in native AOT testing
Using index info to reconstruct a base tree...
A	eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml
M	eng/pipelines/runtime-sanitized.yml
M	eng/pipelines/runtime.yml
M	eng/testing/linker/trimmingTests.targets
Falling back to patching base and 3-way merge...
Auto-merging eng/testing/linker/trimmingTests.targets
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/pipelines/runtime-sanitized.yml
CONFLICT (modify/delete): eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml deleted in HEAD and modified in Stop building AppHost in native AOT testing. Version Stop building AppHost in native AOT testing of eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Stop building AppHost in native AOT testing
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@ilonatommy an error occurred while backporting to release/8.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing as NativeAOT should not depend on AppHost
3 participants