-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop building AppHost in native AOT testing #101270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming all the AOT legs still pass, this change looks reasonable to me.
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10175899693 |
@ilonatommy backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Stop building AppHost in native AOT testing
Using index info to reconstruct a base tree...
A eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml
M eng/pipelines/runtime-sanitized.yml
M eng/pipelines/runtime.yml
M eng/testing/linker/trimmingTests.targets
Falling back to patching base and 3-way merge...
Auto-merging eng/testing/linker/trimmingTests.targets
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/pipelines/runtime-sanitized.yml
CONFLICT (modify/delete): eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml deleted in HEAD and modified in Stop building AppHost in native AOT testing. Version Stop building AppHost in native AOT testing of eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Stop building AppHost in native AOT testing
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@ilonatommy an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
I think this was only needed because the AOT app tests were not doing the right form of publish.
Fixes #79575.
Cc @dotnet/ilc-contrib @eerhardt