Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASI] update SDK 22 and wasmtime 19.0.2 #101392

Merged
merged 9 commits into from
Apr 25, 2024
Merged

[WASI] update SDK 22 and wasmtime 19.0.2 #101392

merged 9 commits into from
Apr 25, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 22, 2024 •
edited
Loading

  • WASI_SDK_VERSION=22
    • this brings LLVM 18
  • WASMTIME_VERSION=19.0.2
  • this disables usage of local installation of WASI SDK and wasmtime if any

see also dotnet/dotnet-buildtools-prereqs-docker#1011

@pavelsavara
WASI_SDK_VERSION=22
60ca737 
WASMTIME_VERSION=19.0.2
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Apr 22, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 22, 2024
@pavelsavara pavelsavara self-assigned this Apr 22, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara mentioned this pull request Apr 22, 2024
Merged
@pavelsavara pavelsavara requested a review from maraf April 22, 2024 17:49
This was referenced Apr 22, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@maraf
Copy link
Member

maraf commented Apr 23, 2024 •
edited
Loading

Does it imply producing WASI SDK 22 from https://github.com/dotnet/wasi-sdk ?

@pavelsavara
Copy link
Member Author

Does it imply producing WASI SDK 22 from https://github.com/dotnet/wasi-sdk ?

That's independent problem. This PR has no such ambition.

This was referenced Apr 23, 2024
Closed
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review April 24, 2024 17:38
@maraf
Copy link
Member

maraf commented Apr 24, 2024 •
edited
Loading

this disables usage of local installation of WASI SDK and wasmtime if any

Are we waiting for docker image or do we want to download these from internet now?

This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

this disables usage of local installation of WASI SDK and wasmtime if any

Are we waiting for docker image or do we want to download these from internet now?

Download from internet for now, it's easier than the other way around and it will unblock me for other things

This was referenced Apr 25, 2024
Closed
Closed
maraf
maraf reviewed Apr 25, 2024
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
@pavelsavara pavelsavara mentioned this pull request Apr 25, 2024
Open
@pavelsavara pavelsavara requested a review from maraf April 25, 2024 07:34
maraf
maraf approved these changes Apr 25, 2024
View reviewed changes
src/mono/mono.proj Outdated Show resolved Hide resolved
src/mono/wasi/wasi.proj Outdated Show resolved Hide resolved
@maraf maraf mentioned this pull request Apr 25, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 25, 2024
Closed
This was referenced Apr 25, 2024
Closed
Closed
Closed
@pavelsavara pavelsavara merged commit d0dffe1 into dotnet:main Apr 25, 2024
151 of 160 checks passed
@pavelsavara pavelsavara deleted the wasi_sdk_wasmtime_updates branch April 25, 2024 12:59
This was referenced Apr 25, 2024
Closed
Closed
Closed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @matouskozak
[WASI] update WASI SDK to 22 and wasmtime to 19.0.2 (dotnet#101392)
badbd8e
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@pavelsavara @michaelgsharp
[WASI] update WASI SDK to 22 and wasmtime to 19.0.2 (dotnet#101392)
f0780cb
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf