-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store last OSR transition context in static memory in DEBUG builds #101537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully will help with diagnosing dotnet#101060 once we get a new dump.
jakobbotsch
changed the title
Avoid overwriting frame context in JIT_Patchpoint
Store last OSR transition context in static memory in DEBUG builds
Apr 25, 2024
AndyAyersMS
approved these changes
Apr 25, 2024
@@ -5144,7 +5144,7 @@ void JIT_Patchpoint(int* counter, int ilOffset) | |||
const int counterBump = g_pConfig->OSR_CounterBump(); | |||
*counter = counterBump; | |||
|
|||
#if _DEBUG | |||
#ifdef _DEBUG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple more of these just below.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…otnet#101537) Hopefully will help with diagnosing dotnet#101060 once we get a new dump.
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…otnet#101537) Hopefully will help with diagnosing dotnet#101060 once we get a new dump.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully will help with diagnosing #101060 once we get a new dump.