Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some TensorPrimitives tests failing for me locally with checked builds #101745

Merged
merged 1 commit into from
May 2, 2024

Conversation

stephentoub
Copy link
Member

This is just:

  • Adding tolerance checks for NFloat that are the same as for float/double
  • Adding tolerance for MultiplyAddEstimate that matches our other tolerances for "Estimate" functions

This addresses everything failing for me locally, but it doesn't match the failure spike recently highlighted in CI.

Related to #101731
Related to #101721

…uilds

This is just:
- Adding tolerance checks for NFloat that are the same as for float/double
- Adding tolerance for MultiplyAddEstimate that matches our other tolerances for "Estimate" functions

This addresses everything failing for me locally, but it doesn't match the failure spike recently highlighted in CI.
@stephentoub stephentoub merged commit fc76b1c into dotnet:main May 2, 2024
81 of 84 checks passed
@stephentoub stephentoub deleted the tptestfix branch May 2, 2024 12:36
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
…uilds (dotnet#101745)

This is just:
- Adding tolerance checks for NFloat that are the same as for float/double
- Adding tolerance for MultiplyAddEstimate that matches our other tolerances for "Estimate" functions

This addresses everything failing for me locally, but it doesn't match the failure spike recently highlighted in CI.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
…uilds (dotnet#101745)

This is just:
- Adding tolerance checks for NFloat that are the same as for float/double
- Adding tolerance for MultiplyAddEstimate that matches our other tolerances for "Estimate" functions

This addresses everything failing for me locally, but it doesn't match the failure spike recently highlighted in CI.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants