Track unknown value as result of unimplemented operations #101752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
sbomer
changed the title
This was referenced May 1, 2024
jtschuster
reviewed
May 1, 2024
| return constValue; | ||
|
|
||
| if (operation.Type is not null) |
There was a problem hiding this comment.
What does it mean when it's null vs nonnull? A comment here might be helpful if it's not in the doc comments for IOperation.Type.
There was a problem hiding this comment.
Null just means it doesn't produce a result: https://learn.microsoft.com/dotnet/api/microsoft.codeanalysis.ioperation.type?view=roslyn-dotnet-4.7.0#microsoft-codeanalysis-ioperation-type
jtschuster
approved these changes
May 1, 2024
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
) Up until now, the analyzer has been set up to return `TopValue` for operations which are not handled by their own `Visit` overrides, to avoid producing warnings that are not produced from ILLink or ILC. This changes the default handling to return `UnknownValue.Instance`, so that such operations produce warnings if the return value flows into a location with dataflow requirements. Fixes dotnet#101733, where the return value of a string interpolation operation (which doesn't have special handling in a `Visit` override) was not producing warnings when passed to `Type.GetType`.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
) Up until now, the analyzer has been set up to return `TopValue` for operations which are not handled by their own `Visit` overrides, to avoid producing warnings that are not produced from ILLink or ILC. This changes the default handling to return `UnknownValue.Instance`, so that such operations produce warnings if the return value flows into a location with dataflow requirements. Fixes dotnet#101733, where the return value of a string interpolation operation (which doesn't have special handling in a `Visit` override) was not producing warnings when passed to `Type.GetType`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the analyzer has been set up to return
TopValuefor operations which are not handled by their ownVisitoverrides, to avoid producing warnings that are not produced from ILLink or ILC. This changes the default handling to returnUnknownValue.Instance, so that such operations produce warnings if the return value flows into a location with dataflow requirements.Fixes #101733, where the return value of a string interpolation operation (which doesn't have special handling in a
Visitoverride) was not producing warnings when passed toType.GetType.