Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Update cdac-build-tool to omit type when it is empty #101825

Merged
merged 1 commit into from
May 6, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented May 2, 2024

This makes it so that if we have datadescriptor.h with something like:

CDAC_TYPE_FIELD(TypeName, /*omit field type*/, FieldName, 8)

The descriptor will be "FieldName":8 instead of "FieldName":[8,""]

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@elinor-fung elinor-fung merged commit f3014db into dotnet:main May 6, 2024
85 of 87 checks passed
@elinor-fung elinor-fung deleted the dataDescriptorEmptyType branch May 6, 2024 17:31
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants