Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Test RPO-based block layout in runtime-jit-experimental #101851

Merged
merged 1 commit into from
May 4, 2024

Conversation

amanasifkhalid
Copy link
Member

Follow-up to #101473. Since the new block layout is disabled by default, we ought to test it periodically.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 3, 2024
@amanasifkhalid amanasifkhalid added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 3, 2024
@amanasifkhalid
Copy link
Member Author

/azp run runtime-jit-experimental

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Member Author

cc @dotnet/jit-contrib

@amanasifkhalid
Copy link
Member Author

runtime-jit-experimental passed, and I can see in the logs that it ran the jitrpolayout configuration.

@AndyAyersMS
Copy link
Member

We should probably enable this in libraries-pgo too. That tends to stress tier1 a bit more.

@amanasifkhalid
Copy link
Member Author

We should probably enable this in libraries-pgo too. That tends to stress tier1 a bit more.

Sure thing, I'll open a follow-up PR to do that.

@amanasifkhalid amanasifkhalid merged commit 00f409f into dotnet:main May 4, 2024
160 of 163 checks passed
@amanasifkhalid amanasifkhalid deleted the jit-experimental branch May 6, 2024 14:50
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants