Fill in FeatureCheckDataflow.cs assertions with issue links #102679
Conversation
…low.cs assertions
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
linkable-framework
| @@ -337,7 +337,7 @@ static void And () | |||
| } | |||
There was a problem hiding this comment.
Above this is one of the tests I couldn't find an issue for.
There was a problem hiding this comment.
Currently we treat this as expected behavior based, described at https://github.com/dotnet/runtime/blob/main/docs/design/tools/illink/feature-checks.md#boolean-andor, but I think we could file an issue to track it and reference that here.
There was a problem hiding this comment.
Made #102830 to track unifying behavior on this.
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FeatureCheckDataFlow.cs
Outdated
Show resolved
Hide resolved
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FeatureCheckDataFlow.cs
Outdated
Show resolved
Hide resolved
| @@ -337,7 +337,7 @@ static void And () | |||
| } | |||
There was a problem hiding this comment.
Currently we treat this as expected behavior based, described at https://github.com/dotnet/runtime/blob/main/docs/design/tools/illink/feature-checks.md#boolean-andor, but I think we could file an issue to track it and reference that here.
jtschuster
added
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
…CheckDataflowIssues
|
/ba-g This only changes trimmer tests. Trimmer tests are passing and failures are unrelated. |
Adds issues links / explanations to FeatureCheckDataflow, and a couple other places.
I couldn't find the issue for the linker and NativeAOT not being able to handle more complex boolean operations with feature switches. Please let me know if you know if the issue does / doesn't exist and I'll link it / make one.