Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GeneratedRegex on partial properties #102977

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

stephentoub
Copy link
Member

Extends the attribute to apply to properties, and updates the source generator to support:

[GeneratedRegex("...")]
private static partial Regex Prop { get; }

in addition to the already supported:

[GeneratedRegex("...")]
private static partial Regex Method();

Closes #77797

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this would require conceptual documentation updates?

@stephentoub
Copy link
Member Author

Presumably this would require conceptual documentation updates?

Yes, we'll want to augment them to highlight the additional feature.

@stephentoub stephentoub merged commit 2bf492b into dotnet:main Jun 3, 2024
79 of 83 checks passed
@stephentoub stephentoub deleted the generatedregexproperty branch June 3, 2024 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GeneratedRegex to support partial properties
5 participants