Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Bundle assets inside of wasm file #103160

Closed
wants to merge 7 commits into from
Closed

[browser] Bundle assets inside of wasm file #103160

wants to merge 7 commits into from
+163 −85

Conversation

maraf
Copy link
Member

@maraf maraf commented Jun 7, 2024 •
edited
Loading

TODO

  • WasmSDK support
  • Choose ICU file name in driver.c or always use full one

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jun 7, 2024
@maraf maraf added this to the 9.0.0 milestone Jun 7, 2024
@maraf maraf self-assigned this Jun 7, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member

which asset types are you going to bundle ?

@maraf
Copy link
Member Author

maraf commented Jun 7, 2024

which asset types are you going to bundle ?

At the moment I have added dlls, icu, runtimeconfig. Thoughts?

  • Runtimeconfig is optional
  • ICU would probably make sense to always bundle the "full" one

This was referenced Jun 7, 2024
Closed
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jun 13, 2024
Closed
@dotnet-policy-service dotnet-policy-service bot removed this from the 9.0.0 milestone Jul 21, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@maraf maraf reopened this Aug 14, 2024
This was referenced Aug 14, 2024
Open
Open
Open
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger will be requested when the pull request is marked ready for review akoeplinger is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy will be requested when the pull request is marked ready for review ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara will be requested when the pull request is marked ready for review pavelsavara is a code owner

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @pavelsavara