[mono] Remove some domain stuff from the debugger

[kg]

cc @lambdageek

[dotnet-policy-service]

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

[lambdageek]

lgtm, I'd use mono_get_root_domain more than mono_domain_get. it's cheaper and doesn't invite questions of "does this function care about being called on an unattached thread?"

[kg]

Does anyone know why https://github.com/dotnet/runtime/pull/103186/files#diff-1492a44134220d0f70af248aa7524cfc5e03795d922b90381eaa3b2fea5955deR96 would be failing? How could we have another domain?

[lambdageek]

Does anyone know why https://github.com/dotnet/runtime/pull/103186/files#diff-1492a44134220d0f70af248aa7524cfc5e03795d922b90381eaa3b2fea5955deR96 would be failing? How could we have another domain?

It's called from here

runtime/src/mono/mono/component/mini-wasm-debugger.c

Line 178 in 07d3637

mono_profiler_set_domain_loaded_callback (prof, appdomain_load);

But the mono_root_domain global is assigned after the profiler event is raised:

runtime/src/mono/mono/metadata/domain.c

Lines 141 to 142 in 07d3637

	domain = create_root_domain ();
	mono_root_domain = domain;

runtime/src/mono/mono/metadata/domain.c

Line 91 in 07d3637

MONO_PROFILER_RAISE (domain_loaded, (domain));

So when mono_de_domain_add executes, mono_get_root_domain is still returning null

[kg]

Does anyone know why https://github.com/dotnet/runtime/pull/103186/files#diff-1492a44134220d0f70af248aa7524cfc5e03795d922b90381eaa3b2fea5955deR96 would be failing? How could we have another domain?

It's called from here

runtime/src/mono/mono/component/mini-wasm-debugger.c

Line 178 in 07d3637

mono_profiler_set_domain_loaded_callback (prof, appdomain_load);

But the mono_root_domain global is assigned after the profiler event is raised:

runtime/src/mono/mono/metadata/domain.c

Lines 141 to 142 in 07d3637

	domain = create_root_domain ();
	mono_root_domain = domain;

runtime/src/mono/mono/metadata/domain.c

Line 91 in 07d3637

MONO_PROFILER_RAISE (domain_loaded, (domain));

So when mono_de_domain_add executes, mono_get_root_domain is still returning null

Thanks! Do you think we should assign the global before firing the profiler event? That seems right to me

[lambdageek]

Do you think we should assign the global before firing the profiler event? That seems right to me

I think so too