Support IAlternateEqualityComparer with FrozenDictionary/Set #103191

stephentoub · 2024-06-08T04:01:45Z

Per the discussion in #27229 (comment), for string keys, this only supports an alternate key of ReadOnlySpan<char>... other alternate key types will fail to return a lookup. That's a compromise to not supporting lookups at all.

dotnet-issue-labeler · 2024-06-08T04:01:51Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-issue-labeler · 2024-06-08T04:01:52Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

src/libraries/System.Collections.Immutable/src/Interfaces.cd

src/libraries/System.Collections.Immutable/src/Resources/Strings.resx

...stem.Collections.Immutable/src/System/Collections/Frozen/FrozenDictionary.AlternateLookup.cs

src/libraries/System.Collections.Immutable/tests/Frozen/FrozenDictionaryAlternateLookupTests.cs

src/libraries/System.Collections.Immutable/tests/Frozen/FrozenSetAlternateLookupTests.cs

Support IAlternateEqualityComparer with FrozenDictionary/Set

ddfaaa4

stephentoub requested review from eiriktsarpalis and tannergooding June 8, 2024 04:01

dotnet-issue-labeler bot added area-System.Collections new-api-needs-documentation labels Jun 8, 2024

dotnet-policy-service bot assigned stephentoub Jun 8, 2024