Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Microsoft.NET.ILLink package #103251

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix Microsoft.NET.ILLink package #103251

merged 1 commit into from
Jun 11, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jun 10, 2024

By removing dependency on ILCompiler.DependencyAnalysisFramework.

Fixes #103249.

@sbomer
Fix Microsoft.NET.ILLink package
a904641 
By removing dependency on ILCompiler.DependencyAnalysisFramework.
@sbomer sbomer requested a review from marek-safar as a code owner June 10, 2024 22:44
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jun 10, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Jun 10, 2024
jtschuster
jtschuster approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This was referenced Jun 11, 2024
Closed
Closed
@ViktorHofer
Copy link
Member

In src/libraries we have a package testing infra that would have caught this. Might make sense to onboard to that.

@sbomer sbomer mentioned this pull request Jun 11, 2024
Open
@sbomer
Copy link
Member Author

sbomer commented Jun 11, 2024

Build analysis says this for the unknown failure:
"Agent failed with exception: The machine running request 4eb80a05-978b-4488-8547-69a1107f03d2 restarted. Azure DevOps can't recover from restarts."

This looks like the same failure mode as #100424 - it looks like it is running forever in github, but on the Azure DevOps side the "Build product" step says "Nothing to show. Final logs are missing. This can happen when the job is cancelled or times out.".

@sbomer
Copy link
Member Author

sbomer commented Jun 11, 2024

/ba-g "Azure DevOps can't recover from restarts. Looks like a known infrastructure issue, #100424"

@sbomer sbomer merged commit 4afb315 into dotnet:main Jun 11, 2024
73 of 76 checks passed
sbomer added a commit to sbomer/runtime that referenced this pull request Jul 1, 2024
@sbomer
Revert "Fix Microsoft.NET.ILLink package (dotnet#103251)"
6ec4a61 
This reverts commit 4afb315.
sbomer added a commit to sbomer/runtime that referenced this pull request Jul 8, 2024
@sbomer
Revert "Revert "Fix Microsoft.NET.ILLink package (dotnet#103251)""
a686b7d 
This reverts commit 6ec4a61.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agocke agocke agocke approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@jtschuster jtschuster jtschuster approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees
No one assigned
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build project referencing latest .NET 9 Preview 6 Microsoft.NET.ILLink package
4 participants
@sbomer @ViktorHofer @agocke @jtschuster