Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Avx512Vbmi.MultiShift #103310

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

tannergooding
Copy link
Member

This resolves #86168.

The PR ended up a bit bigger than expected because I found some issues in the GenerateHWIntrinsicTests_X86.cs file where things didn't line up or weren't getting tested as expected. The actual JIT change is just 6 lines

The tests are mostly just a refactoring, reducing the number of projects to be consistent with how other ISAs are setup. However, Avx512CD was notably not being tested and the Avx512Verify.DetectConflicts helper had a minor bug which was fixed as part of this.

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels Jun 11, 2024
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT changes are simple, looks good.

@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib for review and @dotnet/avx512-contrib as an FYI

As per the top post, the actual JIT work is small and only 6 lines (just adding entries to the tables and the perf score support). The rest of this is fixing the tests to ensure that the new APIs (and some existing APIs) are actually getting executed.

@tannergooding tannergooding merged commit 7d23d61 into dotnet:main Jun 12, 2024
171 of 174 checks passed
@tannergooding tannergooding deleted the avx512-multishift branch June 12, 2024 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor cleanup of approved Avx512 API surface
2 participants