Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64-mono] Part-5:Add loongarch support in some files for LoongArch64 #103398

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[LoongArch64-mono] Part-5:Add loongarch support in some files for LoongArch64 #103398

wants to merge 6 commits into from

Conversation

lawn123
Copy link
Contributor

@lawn123 lawn123 commented Jun 13, 2024

Add a new archecture LoongArch64 for mono.This PR is about loongarch support in some files.

@lawn123
[LoongArch64-mono] Part-5:Add loongarch support in some files for Loo…
5b6f6c9 
…ngArch64

Change-Id: I52c8c227fdeeee840cad14496e24e93a04521143
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 13, 2024
@lawn123
Copy link
Contributor Author

lawn123 commented Jun 13, 2024

@shushanhf

am11
am11 reviewed Jun 13, 2024
View reviewed changes
src/mono/CMakeLists.txt
@@ -392,6 +392,8 @@ elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "i686" OR CMAKE_SYSTEM_PROCESSOR STREQUAL
set(CMAKE_SYSTEM_PROCESSOR "x86")
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "ARM64")
set(CMAKE_SYSTEM_PROCESSOR "arm64")
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "loongarch64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "LOONGARCH64")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add

runtime/src/mono/mono.proj

Lines 457 to 461 in 4f9cd4d

<!-- riscv64 Linux cross build options -->
<ItemGroup Condition="'$(MonoCrossDir)' != '' and '$(TargetArchitecture)' == 'riscv64'">
<_MonoCMakeArgs Include="-DCMAKE_TOOLCHAIN_FILE=$(CrossToolchainFile)" />
<_MonoBuildEnv Include="TARGET_BUILD_ARCH=riscv64" />
</ItemGroup>
to enable LA64 mono cross-build.

@lawn123 lawn123 mentioned this pull request Jun 13, 2024
Draft
@am11 am11 requested a review from akoeplinger June 13, 2024 09:18
@lawn123
Copy link
Contributor Author

lawn123 commented Jun 13, 2024

@am11 Thank you very much. I have added the code you suggested to this PR.

This was referenced Jun 13, 2024
Closed
Open
Closed
Closed
Closed
@jkotas jkotas marked this pull request as draft October 14, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shushanhf shushanhf shushanhf left review comments

@am11 am11 am11 left review comments

@lambdageek lambdageek Awaiting requested review from lambdageek

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
arch-loongarch64 area-Build-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawn123 @am11 @shushanhf