Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Use DynamicDependencyAttribute contructor friendly to InternalsVisibleTo when registering JSExports #103402

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Jun 13, 2024

Instead of using typeof(__GeneratedInitializer), use overload with string typeName and assemblyName

Fixes #103205

@maraf maraf marked this pull request as ready for review June 13, 2024 12:58
@maraf maraf merged commit f1c5823 into dotnet:main Jun 13, 2024
33 of 35 checks passed
@maraf maraf deleted the BrowserJsExportRegistrationInternal branch June 13, 2024 20:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSexport regression in .NET 9 SDK preview 4
2 participants