-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not set UseNativeAotForComponents for arm32 MUSL #103469
Conversation
Not clear why we can't find path to ILC, but this is failing official builds and we need to unblock. ``` error MSB3073: The command ""\tools\\ilc" @"/__w/1/s/artifacts/obj/cdacreader/Release/net9.0/linux-musl-arm/native/libcdacreader.ilc.rsp"" exited with code 127. ```
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
How does official build do things differently that it doesn't fail otherwise? Preview 5 has all these packages? Please trigger the nativeaot pipeline in #103375 so we can see if that fixes it naturally. |
We don't have any CI coverage for these legs. I triggered the outerloop but now I see it won't do anything for arm32 MUSL anyway. This is failing in the official build when we're building runtime packs for native AOT (it's the same thing for the bionic legs). The command it's running is:
I'm pretty sure it found the package or restore would fail. We just don't compute the right path to it for whatever reason. This shouldn't even be building the cdacreader, but the project injects itself into everything. |
On a different official build leg that runs
it does seem to succeed. For context, we didn't have a successful official build for more than a week (publicly you can see there's no dotnet/runtime flow to dotnet/sdk). This is now the top issue that blocks from reaching the other broken parts that other people are trying to fix. If this doesn't work, we'll need to do rollbacks and try again at a less sensitive time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since src/native/managed is likely to have more projects in the future, we may want to make the properties resolution deterministic. (I tested the build on alpine armv7 and it was working then) |
/ba-g restore errors unrelated |
* Revert "Do not set UseNativeAotForComponents for arm32 MUSL (#103469)" This reverts commit f1f0750. * Revert "Set UseNativeAotForComponents to false on bionic (#103454)" This reverts commit d901213. * Revert "Try fixing x86 Windows legs (#103411)" This reverts commit 6927fea. * Revert "Consolidate <NativeAotSupported definitions (#103273)" This reverts commit b86c463.
Not clear why we can't compute correct path to ILC, but this is failing official builds and we need to unblock.